Skip to content

Accept array-like time inputs in rv #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SuperdoerTrav merged 1 commit into from
Sep 19, 2026
Merged

Accept array-like time inputs in rv #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ssapy/compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ def _countTime(time):
time = np.array([time])
nTime = 1
squeezeTime = True
else:
time = np.asarray(time)
return nTime, squeezeTime, time


Expand Down
18 changes: 18 additions & 0 deletions tests/test_orbit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,6 +631,24 @@ def test_rv():
np.testing.assert_allclose(v, v2, rtol=0, atol=1e-2)


def test_rv_accepts_list_and_tuple_times():
orbit = ssapy.Orbit(
np.array([7000e3, 0.0, 0.0]),
np.array([0.0, 7500.0, 0.0]),
0.0,
)
times = [0.0, 60.0, 120.0]

r_list, v_list = ssapy.rv(orbit, times)
r_tuple, v_tuple = ssapy.rv(orbit, tuple(times))
r_array, v_array = ssapy.rv(orbit, np.asarray(times))

np.testing.assert_allclose(r_list, r_array)
np.testing.assert_allclose(v_list, v_array)
np.testing.assert_allclose(r_tuple, r_array)
np.testing.assert_allclose(v_tuple, v_array)


@timer
# def test_groundTrack():
# np.random.seed(5772156)
Expand Down
Loading