Repository navigation
Fix run_extraction TypeError in augment/run CLI commands - #92
Merged
Merged
Conversation
#73 made sess_options a required positional argument of run_extraction, but the augment and run CLI commands still call run_extraction(config), so both crash with a TypeError after augmentation. Default sess_options to None, matching WakeWordModel, and add a regression test.
|
Thanks for this fix. Flagging that it isn't in a published release yet: PyPI's latest is still 0.3.0, and its attestation shows it was built from It's an expensive one to hit, because Would a patch release including from livekit.wakeword.data.features import run_extraction
from livekit.wakeword.session import session_options
run_extraction(config, session_options()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
livekit-wakeword augmentandlivekit-wakeword runcrash after augmentation in v0.2.2:#73 added
sess_optionstorun_extractionas a required argument, but the two CLI callers (cli.py:292,cli.py:398) still callrun_extraction(config). CI didn't catch it because no test goes throughrun_extractionand CI doesn't run mypy.Fix
sess_optionstoNoneinrun_extraction, matchingWakeWordModel.__init__. The mel/embedding wrappers already handleNoneviasession_options().run_extraction(config)withoutsess_options. It fails with theTypeErrorbefore this change and passes after.Testing
uv run pytest: 74 passed, 2 skippedhey_reachypipeline that had crashed at step 3, and feature extraction now runs.