Skip to content

fix: add missing default for sess_options in run_extraction() - #88

Open
sollaluigi05-oss wants to merge 1 commit into
livekit:mainfrom
sollaluigi05-oss:fix/run-extraction-missing-default
Open

sollaluigi05-oss wants to merge 1 commit into
livekit:mainfrom
sollaluigi05-oss:fix/run-extraction-missing-default

Conversation

@sollaluigi05-oss

Copy link
Copy Markdown

Bug

run_extraction() in src/livekit/wakeword/data/features.py is called
without a sess_options argument from the augment CLI stage
(cli.py:292), but the function signature requires it as a positional
argument with no default:

def run_extraction(config: WakeWordConfig, sess_options: SessionOptions) -> None:

This raises:

TypeError: run_extraction() missing 1 required positional argument: 'sess_options'

Every other place in the codebase that takes sess_options already has
a default of None (feature_extractor.py:32, :40, inference/model.py:41,
:73) — this appears to be an oversight from the recent ONNX
export/quantization changes (commit 431c7e4).

Fix

Add the missing default, consistent with the rest of the codebase.

Reproduction

uv sync --all-extras
livekit-wakeword generate configs/prod.yaml
livekit-wakeword augment configs/prod.yaml  # fails here

Tested on macOS (Apple Silicon, MPS backend).

@CLAassistant

CLAassistant commented Sep 18, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants