Repository navigation
fix: add missing default for sess_options in run_extraction() - #88
Open
sollaluigi05-oss wants to merge 1 commit into
Open
sollaluigi05-oss wants to merge 1 commit into
sollaluigi05-oss wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
run_extraction()insrc/livekit/wakeword/data/features.pyis calledwithout a
sess_optionsargument from theaugmentCLI stage(
cli.py:292), but the function signature requires it as a positionalargument with no default:
This raises:
TypeError: run_extraction() missing 1 required positional argument: 'sess_options'
Every other place in the codebase that takes
sess_optionsalready hasa default of
None(feature_extractor.py:32,:40,inference/model.py:41,:73) — this appears to be an oversight from the recent ONNXexport/quantization changes (commit 431c7e4).
Fix
Add the missing default, consistent with the rest of the codebase.
Reproduction
uv sync --all-extras livekit-wakeword generate configs/prod.yaml livekit-wakeword augment configs/prod.yaml # fails hereTested on macOS (Apple Silicon, MPS backend).