Payment triggers use a multirange window - #942
Merged
Merged
Conversation
Registration links use ical events, and up till now only had a single way to edit them, using text rrules. This adds a GUI-based rrule editor. Off-the-shelf options had many issues. It also refactors some backend ical stuff for reuse.
Remove subdivide, since it gives us a bunch of hard-to-use triggers with small windows. Instead, just store the multirange of payment trigger times.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
==========================================
- Coverage 99.79% 99.78% -0.01%
==========================================
Files 755 757 +2
Lines 38223 38310 +87
==========================================
+ Hits 38143 38228 +85
- Misses 80 82 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a single 'active during' window for triggers,
they now can use a multirange (just added to sequel-tstzrange-fields plugin).
Each 'window' has its own accumulation of subsidies.
This was a straightforward backend change
but required a big admin change to add icalendar support.
Add GUI-based icalendar event editor
Registration links use ical events,
and up till now only had a single way to edit them,
using text rrules.
This adds a GUI-based rrule editor.
Off-the-shelf libraries had many issues.
It also refactors some backend ical stuff for reuse.