Analytics charges; staging restore script; signup agreement checkbox fix; marketing dispatch error save - #936
Merged
Merged
Conversation
We need to know when the charge was incurred by the user, not when Suma processed it, for example if we have to do a historical import.
It's only valid for local dev, since it contains potentially sensitive data; it should not be used in places like staging.
This adds a new rake task that can be used to restore a production dump to a staging database, removing all non-admin member data. This ensures that even if someone makes it to staging or somehow grabs a copy of the DB, no member data is included.
Found while working on the release fixup, these should logically already be CASCADE.
Clicking the div would update the React state, but not the React Hook Form state, which works based on the native input state, which isn't changing with React's rendering. This uses refs to keep things in sync, and drives the state from the checkbox rather than higher up state created through React.useState.
We were losing error information.
rgalanakis
force-pushed
the
analytics-charge-obj-created
branch
from
June 26, 2026 04:07
1a5b09c to
104e88a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
==========================================
- Coverage 99.79% 99.78% -0.01%
==========================================
Files 755 755
Lines 37871 37983 +112
==========================================
+ Hits 37793 37901 +108
- Misses 78 82 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marketing SMS dispatch: Save to DB on error
We were losing error information.
Fix signup agreement div click issue
Clicking the div would update the React state,
but not the React Hook Form state, which works based on the native
input state, which isn't changing with React's rendering.
This uses refs to keep things in sync, and drives the state
from the checkbox rather than higher up state
created through React.useState.
Convert some FKs to ON DELETE CASCADE
Found while working on the release fixup,
these should logically already be CASCADE.
Support secure restores to staging
This adds a new rake task that can be used to restore a production dump
to a staging database, removing all non-admin member data.
This ensures that even if someone makes it to staging or
somehow grabs a copy of the DB, no member data is included.
Rename prepare_prod_db_for_testing
It's only valid for local dev, since it contains potentially
sensitive data; it should not be used in places like staging.
Analytics: Add charge.incurred_at
We need to know when the charge was incurred by the user,
not when Suma processed it, for example if we have to do
a historical import.