Fix imagemagick - #336
Merged
Merged
Conversation
Member
Author
|
Probably on the right track here, but this seems to have broken some images (made them appear blank). Not sure why. |
nemchik
marked this pull request as draft
July 4, 2026 01:42
Member
Author
|
Fixed the blank images in c072ddc but now repeat runs modify all files every time. |
Member
Author
|
Rox mentioned moving away from auto-resizing and instead just detect when images are larger than we want via GHA and fail the CI/CD. Closing in favor of that idea. |
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
nemchik
force-pushed
the
fix-imagemagick
branch
7 times, most recently
from
July 11, 2026 21:13
cda114a to
02f612a
Compare
Signed-off-by: Eric Nemchik <eric@nemchik.com>
quietsy
approved these changes
Jul 12, 2026
nemchik
marked this pull request as ready for review
July 12, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change here is using
mogrifyinstead ofconvert. It seems likeconvertmay be deprecated.A side objective was simplifying the bash logic just a little bit to use a for loop instead of find, but this does call
identifytwice to get the width and height separately. IMHO it's slightly easier to read.Lastly, the planka logo had something wrong with it that imagemagick didn't like, so I replaced that with a new copy from their repo.