Skip to content

[cinnamon-screenshot@hilyxx] V1.3.3 - Ready for LM23 - #1138

Open
Hilyxx wants to merge 3 commits into
linuxmint:masterfrom
Hilyxx:cinnamon-screenshot
Open

[cinnamon-screenshot@hilyxx] V1.3.3 - Ready for LM23#1138
Hilyxx wants to merge 3 commits into
linuxmint:masterfrom
Hilyxx:cinnamon-screenshot

Conversation

@Hilyxx

@Hilyxx Hilyxx commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
  • Improve compatibility with cinnamon 6.8 (Remove deprecated require() and module.exports)

Hilyxx added 2 commits August 20, 2026 16:53
* Improve compatibility with cinnamon 6.8 (Remove deprecated require() and module.exports)
revert locale path to align with Cinnamon Spices
@Hilyxx
Hilyxx marked this pull request as draft August 20, 2026 16:49
@Hilyxx

Hilyxx commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

I relied on a comment stating that using GLib.get_user_data_dir() could cause a silent failure if the XDG_DATA_HOME variable was modified, so I changed it accordingly to follow Spices.py, which hard-coded the path as locale_inst = f'{home}/.local/share/locale'.
However, I went back and checked, and the code has since been completely refactored and moved to harvester.py, which does use GLib.get_user_data_dir().
So I’m reverting my change and switching it back to the way it was originally.

@Hilyxx
Hilyxx marked this pull request as ready for review August 20, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant