chore: update cmake minimum required version in template#643
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideIncrease the minimum required CMake version in the qml-app-template main CMakeLists to a more modern baseline to avoid warnings on newer toolchains. Flow diagram for updated cmake_minimum_required version checkflowchart LR
A[cMakeLists.txt] --> B(cmake_minimum_required VERSION 3.16)
B --> C{cmake_version >= 3.16}
C -->|yes| D[Configure project without minimum version warning]
C -->|no| E[Fail configuration or emit error]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider aligning this minimum CMake version with whatever global/project-wide minimum is defined elsewhere so templates don’t drift and create confusing inconsistencies for consumers.
- If the template actually relies on features introduced in 3.16, it might be helpful to add a brief comment in the CMakeLists explaining why 3.16 is required to justify the bump for future maintainers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider aligning this minimum CMake version with whatever global/project-wide minimum is defined elsewhere so templates don’t drift and create confusing inconsistencies for consumers.
- If the template actually relies on features introduced in 3.16, it might be helpful to add a brief comment in the CMakeLists explaining why 3.16 is required to justify the bump for future maintainers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
deepin pr auto review★ 总体评分：100分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 cmake_minimum_required(VERSION 3.16)
set(APP_BIN_INSTALL_DIR ${CMAKE_INSTALL_PREFIX}/bin/)
set(APP_NAME ${CMAKE_PROJECT_NAME}) |
18202781743
approved these changes
Jul 2, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
更新 qml-app-template 中 CMakeLists.txt 要求的 CMake 版本，避免过低导致警告 Log:
18202781743
force-pushed
the
cmake-min-ver
branch
from
74cdf9d to
6a10337
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
更新 qml-app-template 中 CMakeLists.txt 要求的 CMake 版本，避免过低导致警告
Log:
Summary by Sourcery
Build: