drbd: Fix potential NULL pointer dereference in _drbd_set_state()#999
Open
blktests-ci[bot] wants to merge 1 commit into
Open
drbd: Fix potential NULL pointer dereference in _drbd_set_state()#999blktests-ci[bot] wants to merge 1 commit into
blktests-ci[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: bade58e |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
7d8604f to
4cc45a3
Compare
Author
|
Upstream branch: 4edcdef |
blktests-ci
Bot
force-pushed
the
series/1116254=>linus-master
branch
from
3237660 to
e7e473f
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
4cc45a3 to
90ffd56
Compare
The connection pointer receives a value in the _drbd_set_state() function, including through a call to the first_peer_device() function. This function returns a pointer to a list element. If the list is empty, it returns a NULL pointer, which is later assigned to the connection pointer. Subsequently, this pointer will be dereferenced. Add a NULL check for the connection pointer to avoid dereferencing an invalid pointer. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: a6b32bc ("drbd: Introduce "peer_device" object between "device" and "connection"") Cc: stable@vger.kernel.org Signed-off-by: Andrey Vatoropin <a.vatoropin@crpt.ru>
Author
|
Upstream branch: dc59e4f |
blktests-ci
Bot
force-pushed
the
series/1116254=>linus-master
branch
from
e7e473f to
b0f05b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: drbd: Fix potential NULL pointer dereference in _drbd_set_state()
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1116254