iomap: Remove FGP_NOFS from iomap_get_folio()#997
Open
blktests-ci[bot] wants to merge 1 commit into
Open
Conversation
Author
|
Upstream branch: bade58e |
7d8604f to
4cc45a3
Compare
Author
|
Upstream branch: 4edcdef |
5d99050 to
fd68e25
Compare
4cc45a3 to
90ffd56
Compare
Author
|
Upstream branch: dc59e4f |
FGP_NOFS is legacy; filesystems should be using memalloc_nofs_save/restore instead. We have it here in iomap because it was buried in grab_cache_page_write_begin() and we didn't want to change this behaviour as part of the folio transition. I have tested this with XFS and see no issues. Other filesystems (cc'd) may need to make adjustments. Please test with lockdep enabled. Cc: "Darrick J. Wong" <djwong@kernel.org> (iomap) Cc: Jens Axboe <axboe@kernel.dk> (block) Cc: Namjae Jeon <linkinjeon@kernel.org> (exfat, ntfs) Cc: Sungjong Seo <sj1557.seo@samsung.com> (exfat) Cc: Yuezhang Mo <yuezhang.mo@sony.com> (exfat) Cc: Miklos Szeredi <miklos@szeredi.hu> (fuse) Cc: Andreas Gruenbacher <agruenba@redhat.com> (gfs2) Cc: Hyunchul Lee <hyc.lee@gmail.com> (ntfs) Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> (ntfs3) Cc: Carlos Maiolino <cem@kernel.org> (xfs) Cc: Damien Le Moal <dlemoal@kernel.org> (zonefs) Cc: Naohiro Aota <naohiro.aota@wdc.com> (zonefs) Cc: Johannes Thumshirn <jth@kernel.org> (zonefs) Cc: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Cc: linux-block@vger.kernel.org Cc: fuse-devel@lists.linux.dev Cc: gfs2@lists.linux.dev Cc: ntfs3@lists.linux.dev Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
fd68e25 to
ab6c825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: iomap: Remove FGP_NOFS from iomap_get_folio()
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1116079