brd: normalize non-positive max_part before rounding it up#945
Open
blktests-ci[bot] wants to merge 1 commit into
Open
brd: normalize non-positive max_part before rounding it up#945blktests-ci[bot] wants to merge 1 commit into
blktests-ci[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: 979c294 |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
a7bb5c5 to
5e41a3b
Compare
Author
|
Upstream branch: acb7500 |
blktests-ci
Bot
force-pushed
the
series/1108157=>linus-master
branch
from
e294502 to
cf302b5
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
5e41a3b to
c3a084b
Compare
Author
|
Upstream branch: 9716c08 |
blktests-ci
Bot
force-pushed
the
series/1108157=>linus-master
branch
from
cf302b5 to
414dc80
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
c3a084b to
5f78e5d
Compare
Author
|
Upstream branch: 2a2974b |
blktests-ci
Bot
force-pushed
the
series/1108157=>linus-master
branch
from
414dc80 to
9ecf8c6
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
5f78e5d to
e48f9db
Compare
Author
|
Upstream branch: 062871f |
blktests-ci
Bot
force-pushed
the
series/1108157=>linus-master
branch
from
9ecf8c6 to
407a53b
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
2 times, most recently
from
199644a to
e6d9eb8
Compare
Author
|
Upstream branch: 66affa3 |
blktests-ci
Bot
force-pushed
the
series/1108157=>linus-master
branch
from
407a53b to
0234d6a
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
e6d9eb8 to
7d8604f
Compare
Author
|
Upstream branch: bade58e |
blktests-ci
Bot
force-pushed
the
series/1108157=>linus-master
branch
from
0234d6a to
0c0eb85
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
7d8604f to
4cc45a3
Compare
Author
|
Upstream branch: 4edcdef |
blktests-ci
Bot
force-pushed
the
series/1108157=>linus-master
branch
from
0c0eb85 to
e8bd33b
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
4cc45a3 to
90ffd56
Compare
`max_part` is an `int` module parameter, but brd only resets zero before rounding non-divisor values with `1UL << fls(max_part)`. A negative value such as -1 passes the initial zero check. The modulo test then reaches the roundup, where `fls(-1)` yields 32. On 64-bit builds that produces 4294967296, which is then assigned back to `int max_part` as zero. `brd_alloc()` passes that zero value to `disk->minors`, and block core warns and rejects the disk. Normalize non-positive values to the existing one-partition fallback before the modulo/roundup, and apply the existing `DISK_MAX_PARTS` clamp before the roundup so it only operates on representable, in-range values. Assisted-by: Codex:gpt-5.5-cyber-preview Signed-off-by: Samuel Moelius <sam.moelius@trailofbits.com>
Author
|
Upstream branch: dc59e4f |
blktests-ci
Bot
force-pushed
the
series/1108157=>linus-master
branch
from
e8bd33b to
7f3e325
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: brd: normalize non-positive max_part before rounding it up
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1108157