rust: aref: make AlwaysRefCounted::inc_ref an associated function#1017
Open
blktests-ci[bot] wants to merge 1 commit into
Open
rust: aref: make AlwaysRefCounted::inc_ref an associated function#1017blktests-ci[bot] wants to merge 1 commit into
AlwaysRefCounted::inc_ref an associated function#1017blktests-ci[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: 4edcdef |
Author
|
Upstream branch: 4edcdef |
c1b14d5 to
0cf4897
Compare
Author
|
Upstream branch: 4edcdef |
0cf4897 to
2b392d4
Compare
4cc45a3 to
90ffd56
Compare
`AlwaysRefCounted::inc_ref` is a function that shouldn't be called lightly. To prevent accidentally calling it, change `inc_ref` to be an associated function. Modify all `AlwaysRefCounted` implementors to work with this change. Suggested-by: Benno Lossin <lossin@kernel.org> Link: Rust-for-Linux/linux#1177 Reviewed-by: Alice Ryhl <aliceryhl@google.com> Signed-off-by: Trevor Chan <trev@trevrosa.dev> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Author
|
Upstream branch: dc59e4f |
2b392d4 to
f7fab90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: rust: aref: make
AlwaysRefCounted::inc_refan associated functionversion: 5
url: https://patchwork.kernel.org/project/linux-block/list/?series=1117606