drbd: Fix double put_ldev in receive_SyncParam on fifo_alloc failure#1007
Open
blktests-ci[bot] wants to merge 1 commit into
Open
drbd: Fix double put_ldev in receive_SyncParam on fifo_alloc failure#1007blktests-ci[bot] wants to merge 1 commit into
blktests-ci[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: bade58e |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
7d8604f to
4cc45a3
Compare
Author
|
Upstream branch: 4edcdef |
blktests-ci
Bot
force-pushed
the
series/1116613=>linus-master
branch
from
73dfac7 to
2f94827
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
4cc45a3 to
90ffd56
Compare
Author
|
Upstream branch: dc59e4f |
In receive_SyncParam(), when the fifo_alloc() call for the resync plan buffer fails, the error path executes put_ldev(device) at line 3790 and then jumps to the disconnect label. The disconnect label also calls put_ldev(device) when new_disk_conf is non-NULL, which is always the case by this point (get_ldev succeeded and new_disk_conf was allocated). This results in a double put_ldev, causing the ldev reference count to underflow. All other goto disconnect sites in the same function correctly rely solely on the disconnect label to perform the single put_ldev — the fifo_alloc failure path was the only one to prematurely release the reference. Remove the spurious put_ldev(device) call before goto disconnect to fix the double put. Cc: stable@vger.kernel.org Fixes: b30ab79 ("drbd: Rename "mdev" to "device"") Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
blktests-ci
Bot
force-pushed
the
series/1116613=>linus-master
branch
from
2f94827 to
26d5440
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: drbd: Fix double put_ldev in receive_SyncParam on fifo_alloc failure
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1116613