Skip to content

chore(deps): group grpc dependabot groups - #3821

Merged
olix0r merged 1 commit into
mainfrom
kate/tonic-dependabot-group-deux
Mar 31, 2025
Merged

olix0r merged 1 commit into
mainfrom
kate/tonic-dependabot-group-deux

Conversation

@cratelyn

Copy link
Copy Markdown
Contributor

* https://github.com/linkerd/linkerd2/blob/main/.github/dependabot.yml#L81-L86
* #3809
* linkerd/linkerd2-proxy-api#455 (comment)

tonic and prost are interconnected. we should bump them in lockstep.

Signed-off-by: katelyn martin <kate@buoyant.io>
@cratelyn
cratelyn marked this pull request as ready for review March 27, 2025 21:42
@cratelyn
cratelyn requested a review from a team as a code owner March 27, 2025 21:42
@olix0r

olix0r commented Mar 27, 2025

Copy link
Copy Markdown
Member

Actually.. doesn't this need to be grouped with linkerd2-proxy-api?

@cratelyn

Copy link
Copy Markdown
Contributor Author

Actually.. doesn't this need to be grouped with linkerd2-proxy-api?

yeah.. in practice we'll only want patch updates from these until the proxy api bumps to a new major/minor version. if it's alright with you, i might punt on that here, since protobufs and how we generate/check bindings are a broader can of worms we'll need to think about in #3810. what do you think?

@olix0r
olix0r merged commit 523d3ed into main Mar 31, 2025
@olix0r
olix0r deleted the kate/tonic-dependabot-group-deux branch March 31, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants