Skip to content

fix(cache): route null decode pages to dummy slot - #1169

Open
jhinpan wants to merge 1 commit into
lightseekorg:mainfrom
jhinpan:jhinpan/fix-1132-null-cache-pages-v2
Open

fix(cache): route null decode pages to dummy slot#1169
jhinpan wants to merge 1 commit into
lightseekorg:mainfrom
jhinpan:jhinpan/fix-1132-null-cache-pages-v2

Conversation

@jhinpan

@jhinpan jhinpan commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • route null or negative page IDs to the fixed dummy slot in both fused target decode prep and DFlash draft prep
  • add boundary, overflow, negative-page, and CUDA-graph replay coverage for the shared cache-location contract

This is an independently landable correctness fix found while investigating #1132. At exact 131K it only changed average accepted length from 1.0000 to 1.0365, so it is not presented as the full acceptance-collapse fix.

Test plan

  • pytest -q test/runtime/test_decode_cache_loc.py test/runtime/test_sliding_cache_loc.py (11 passed on gfx950)
  • isort --check-only and black --check on the changed Python files
  • exact 131072/1024 TP8/EP8 DSpark A/B with the draft guard enabled

Keep fused target and DFlash decode writes consistent with the general cache-location contract so null or reclaimed pages cannot scatter writes across page zero.

Signed-off-by: Jin Pan <jin.pan@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant