RFC: LDK Review Club visual redesign - #61
Open
vincenzopalazzo wants to merge 3 commits into
Open
Conversation
Recreate the Claude Design handoff (LDK Review Club.dc.html) as a Jekyll theme with dark terminal styling, sidebar navigation, marquee ticker, and redesigned home, meetings, and PR detail pages. Adds RFC 001 documenting the proposal and preview banner flags in _config.yml for community review before merging to main.
Kramdown was escaping HTML inside index.md as a code block. Convert the home page to index.html and move the upcoming meeting block into an include so Liquid output renders as markup.
Several meeting posts use status: done instead of past. Treat both as completed so the home page recent meetings section stays accurate.
✅ Deploy Preview for ldk-review-club ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for courageous-frangipane-fab648 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#FFD60Aaccent, sidebar nav, marquee ticker)docs/rfc/001-site-redesign.md) and a preview banner (redesign_rfc: true) for community feedback before removing the flag on mergeindex.htmland extracts Liquid/HTML blocks into includes to avoid kramdown escaping meeting cardscurb,rake, minitest) sobundle installworks without native curl extensions for site buildsReview Notes
upstream/main(includes #3886 host/date fixes).log-lineCSSDecision Log
Hardest decision: Converting
index.mdtoindex.htmlinstead of fighting kramdown's code-block escaping for the upcoming-meeting Liquid loop. The markdown processor was rendering the entire meeting card as escaped plaintext — includes alone weren't enough while the page stayed.md. An HTML front-matter page is the standard Jekyll escape hatch and keeps all other content paths unchanged.Alternatives rejected:
markdown="0"wrapper on a div: inconsistent across Jekyll/kramdown versions and still fragile with nested Liquid_layouts/home.html: harder to maintain and diverges from how other pages usedefaultlayoutLeast confident about: Whether dropping the old
.log-line/ IRC transcript styles breaks readability on any past meeting pages that embed chat logs. I didn't find active log markup in current posts, but if any exist in rendered output we should restore scoped log styles in a follow-up.Test plan