fix(service): replace unusable tmux advice on hosts with no service manager (#479) - #486
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 26, 2026
…anager A systemd-less container (PID 1 = tini) falls through every backend branch, and the message it hit told the operator to run `jaw serve` under tmux/screen. That is not a recipe they can follow: they arrived here from a one-shot `ssh host '...'` command, which has no interactive session for a multiplexer to attach to, and tmux would inherit the same non-interactive PATH that just failed to resolve `jaw`. The replacement is what the reporter had to work out by hand: absolute node and jaw paths (nothing to resolve), setsid so the process outlives the SSH connection, stdin from /dev/null so it never blocks on a vanishing terminal, and a log to read when it dies. It also names the liveness check, since the #479 failure mode is silence rather than an error. The docker branch had the same shape of problem: it printed "the container's restart policy manages this" and exited 0 even when jaw was not the container's entrypoint, so `jaw service` reported success having started nothing. It now says so and prints the same manual recipe. Refs #479
parkjs101
force-pushed
the
codex/479-service-guidance
branch
from
August 26, 2026 10:53
0172cf6 to
419132d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The message
jaw serviceprinted on a host with no service manager told the operator to runjaw serveunder tmux/screen. This replaces it with a recipe that works, and fixes the same class of problem in the docker branch.Why the old advice could not be followed
Operators reach that message from a one-shot
ssh host '...'command. A terminal multiplexer needs an interactive session to attach to, which is exactly what that does not have — and tmux would inherit the same non-interactive PATH that just failed to resolvejaw, so it would fail for the original reason.What replaces it
What the #479 reporter had to work out by hand:
jawis what fails heresetsid< /dev/null>> …logIt also names the liveness check and the log path, because the #479 failure mode is silence rather than an error.
Docker branch
Same shape of problem: it printed "the container's restart policy manages this" and exited 0 even when jaw was not the container's entrypoint — so
jaw servicereported success having started nothing. It now says so and prints the same recipe.Verification
Rendered with the reporter's exact paths; output matches the workaround they arrived at independently. 7 unit tests (
tests/unit/manual-supervision.test.ts),tsc --noEmitclean.One test is deliberately narrow: it scans only
console.*lines for tmux/screen, so a comment may still explain why the advice was removed.Refs #479
Stack (merge bottom-up):
Review this PR's diff only; its base is the layer below.