Skip to content

Drop stray override on non-virtual mock destructors #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kammce merged 1 commit into from
Aug 23, 2026
Merged

Drop stray override on non-virtual mock destructors #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions v1/test_package/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ void pump(async::future<T>& p_future, hal::usize p_max_steps = 50)
class stub_control_endpoint : public hal::usb::control_endpoint
{
public:
~stub_control_endpoint() override = default;
~stub_control_endpoint() = default;

hal::usize m_connect_calls = 0;

Expand Down Expand Up @@ -114,7 +114,7 @@ class stub_control_endpoint : public hal::usb::control_endpoint
class stub_interface : public hal::usb::interface
{
public:
~stub_interface() override = default;
~stub_interface() = default;

private:
async::future<descriptor_count> driver_write_descriptors(
Expand Down
4 changes: 2 additions & 2 deletions v1/tests/test_util.cppm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ void pump(async::future<T>& p_future, hal::usize p_max_steps = 500)
export class mock_control_endpoint : public hal::usb::control_endpoint
{
public:
~mock_control_endpoint() override = default;
~mock_control_endpoint() = default;

void set_read_data(std::span<hal::byte const> p_data)
{
Expand Down Expand Up @@ -225,7 +225,7 @@ private:
export class mock_interface : public hal::usb::interface
{
public:
~mock_interface() override = default;
~mock_interface() = default;

bool m_handle_request_result = false;
bool m_write_string_result = false;
Expand Down
Loading