Skip to content

Migrate to the prototype visitor API #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
liamappelbe wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Migrate to the prototype visitor API #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,117 changes: 1,220 additions & 897 deletions sqlite3/lib/src/ffi/libsqlite3.g.dart
View file
Open in desktop

Large diffs are not rendered by default.

134 changes: 67 additions & 67 deletions sqlite3/lib/src/hook/compile/used_symbols.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,96 +3,96 @@

// dart format off
const usedSqliteSymbols = {

@dcharkes dcharkes Jul 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the definition order change with a newer ffigen version?

@liamappelbe liamappelbe Jul 29, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point I started aggressively sorting AST elements to make the generation more deterministic across machines. That would probably explain this diff.

'sqlite3_temp_directory',
'sqlite3_initialize',
'sqlite3_free',
'sqlite3_open_v2',
'sqlite3_close_v2',
'sqlite3_db_filename',
'sqlite3_compileoption_used',
'sqlite3_compileoption_get',
'sqlite3_busy_handler',
'sqlite3_extended_result_codes',
'sqlite3_extended_errcode',
'sqlite3_errmsg',
'sqlite3_errstr',
'sqlite3_error_offset',
'sqlite3_libversion',
'sqlite3_sourceid',
'sqlite3_libversion_number',
'sqlite3_last_insert_rowid',
'sqlite3_changes',
'sqlite3_exec',
'sqlite3_update_hook',
'sqlite3_commit_hook',
'sqlite3_rollback_hook',
'sqlite3_get_autocommit',
'sqlite3_prepare_v2',
'sqlite3_prepare_v3',
'sqlite3_finalize',
'sqlite3_step',
'sqlite3_reset',
'sqlite3_stmt_isexplain',
'sqlite3_stmt_readonly',
'sqlite3_column_count',
'sqlite3_bind_parameter_count',
'sqlite3_bind_parameter_index',
'sqlite3_column_name',
'sqlite3_column_table_name',
'sqlite3_aggregate_context',
'sqlite3_auto_extension',
'sqlite3_backup_finish',
'sqlite3_backup_init',
'sqlite3_backup_pagecount',
'sqlite3_backup_remaining',
'sqlite3_backup_step',
'sqlite3_bind_blob64',
'sqlite3_bind_double',
'sqlite3_bind_int64',
'sqlite3_bind_null',
'sqlite3_bind_parameter_count',
'sqlite3_bind_parameter_index',
'sqlite3_bind_text',
'sqlite3_busy_handler',
'sqlite3_changes',
'sqlite3_close_v2',
'sqlite3_column_blob',
'sqlite3_column_bytes',
'sqlite3_column_count',
'sqlite3_column_double',
'sqlite3_column_int64',
'sqlite3_column_name',
'sqlite3_column_table_name',
'sqlite3_column_text',
'sqlite3_column_bytes',
'sqlite3_column_type',
'sqlite3_value_blob',
'sqlite3_value_double',
'sqlite3_value_type',
'sqlite3_value_int64',
'sqlite3_value_text',
'sqlite3_value_bytes',
'sqlite3_value_subtype',
'sqlite3_commit_hook',
'sqlite3_compileoption_get',
'sqlite3_compileoption_used',
'sqlite3_create_collation_v2',
'sqlite3_create_function_v2',
'sqlite3_create_window_function',
'sqlite3_aggregate_context',
'sqlite3_user_data',
'sqlite3_db_config',
'sqlite3_db_filename',
'sqlite3_errmsg',
'sqlite3_error_offset',
'sqlite3_errstr',
'sqlite3_exec',
'sqlite3_extended_errcode',
'sqlite3_extended_result_codes',
'sqlite3_finalize',
'sqlite3_free',
'sqlite3_get_autocommit',
'sqlite3_initialize',
'sqlite3_last_insert_rowid',
'sqlite3_libversion',
'sqlite3_libversion_number',
'sqlite3_open_v2',
'sqlite3_prepare_v2',
'sqlite3_prepare_v3',
'sqlite3_reset',
'sqlite3_result_blob64',
'sqlite3_result_double',
'sqlite3_result_error',
'sqlite3_result_int64',
'sqlite3_result_null',
'sqlite3_result_text',
'sqlite3_result_subtype',
'sqlite3_create_collation_v2',
'sqlite3_backup_init',
'sqlite3_backup_step',
'sqlite3_backup_finish',
'sqlite3_backup_remaining',
'sqlite3_backup_pagecount',
'sqlite3_auto_extension',
'sqlite3_db_config',
'sqlite3_result_text',
'sqlite3_rollback_hook',
'sqlite3_sourceid',
'sqlite3_step',
'sqlite3_stmt_isexplain',
'sqlite3_stmt_readonly',
'sqlite3_temp_directory',
'sqlite3_update_hook',
'sqlite3_user_data',
'sqlite3_value_blob',
'sqlite3_value_bytes',
'sqlite3_value_double',
'sqlite3_value_int64',
'sqlite3_value_subtype',
'sqlite3_value_text',
'sqlite3_value_type',
'sqlite3_vfs_register',
'sqlite3_vfs_unregister',
'sqlite3session_create',
'sqlite3session_delete',
'sqlite3session_enable',
'sqlite3session_indirect',
'sqlite3changeset_start',
'sqlite3changeset_apply',
'sqlite3changeset_finalize',
'sqlite3changeset_invert',
'sqlite3changeset_new',
'sqlite3changeset_next',
'sqlite3changeset_op',
'sqlite3changeset_old',
'sqlite3changeset_new',
'sqlite3changeset_apply',
'sqlite3changeset_invert',
'sqlite3session_patchset',
'sqlite3session_changeset',
'sqlite3session_isempty',
'sqlite3changeset_op',
'sqlite3changeset_start',
'sqlite3session_attach',
'sqlite3session_changeset',
'sqlite3session_create',
'sqlite3session_delete',
'sqlite3session_diff',
'sqlite3session_enable',
'sqlite3session_indirect',
'sqlite3session_isempty',
'sqlite3session_patchset',
};
Loading