Skip to content

fix(fullscreen): add native Promise methods and error events - #1868

Open
ldm0 wants to merge 1 commit into
wpt/20261022-fullscreen-native-attributesfrom
wpt/20261022-fullscreen-native-bindings
Open

ldm0 wants to merge 1 commit into
wpt/20261022-fullscreen-native-attributesfrom
wpt/20261022-fullscreen-native-bindings

Conversation

@ldm0

@ldm0 ldm0 commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Add native requestFullscreen / exitFullscreen Promise bindings and fullscreen event handlers on top of the readonly attribute PR. Use the shared Promise adapter and derived FullscreenOptions conversion before acquiring runtime state; preserve callee-realm rejections and original conversion exceptions. Queue unsupported-platform fullscreenerror events as browser internal tasks owned by the target document, so clearTimeout and retiring a borrowed method's Window cannot cancel them.

Retain all 1,361 full binding checks, the Document receiver matrix and registered native Proxy regressions. Add a regression covering both timer cancellation attempts and a retired callee realm. Actual fullscreen remains unsupported (fullscreenEnabled=false). The options and event behavior follow the Fullscreen standard.

Depends on #1867.

Validation on base 2b44a137ff1e: cargo fmt --all; cargo clippy --workspace --all-targets --all-features -- -D warnings; cargo nextest run --no-fail-fast. All passed (20,534 passed, 18 existing skips; 32 build jobs and test threads, no automatic retries). Focused regressions also passed.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Sequential Navigation Soak A/B

✅ HEAD completed the 200-navigation resilience and memory observation.

One browser process, one target, and one CDP session navigate CSDN → SegmentFault → Huaban → example.com repeatedly. This run issued 200 Page.navigate commands per binary.

Common ancestor 2b44a137ff → HEAD 0961868aa6; benchmark order: base-first; workflow: success.

Session resilience

Metric Base HEAD
Attempted / planned 200 / 200 200 / 200
Direct observable pass 200 / 200 199 / 200
Failures / recovered 0 / 0 1 / 1
Recovery failures 0 0
Lifecycle order violations 0 0
Network order violations 0 0
Wall time 578.2 s 560.7 s

A public-page failure is reported separately from an unrecoverable session. The soak requires all navigation attempts, zero failed recovery, zero lifecycle/network ordering violations, and complete resource evidence.

Process-tree memory

Metric Base HEAD Δ
Boundary samples 200 200 0
Boundary RSS samples 200 200 0
Boundary PSS samples 200 200 0
Periodic peak RSS 245.5 MiB 259.6 MiB +14.1 MiB
Periodic peak PSS 242.1 MiB 256.3 MiB +14.2 MiB
RSS · first 10 avg 163.8 MiB 171.2 MiB +7.4 MiB
RSS · last 10 avg 203.3 MiB 196.4 MiB -6.9 MiB
RSS · last − first window +39.5 MiB +25.2 MiB -14.3 MiB
RSS · warm slope / 100 nav +8.1 MiB +9.3 MiB +1.2 MiB
PSS · first 10 avg 160.7 MiB 168.0 MiB +7.2 MiB
PSS · last 10 avg 199.8 MiB 193.6 MiB -6.2 MiB
PSS · last − first window +39.1 MiB +25.6 MiB -13.4 MiB
PSS · warm slope / 100 nav +8.0 MiB +9.1 MiB +1.1 MiB
Peak file descriptors 57 57 0
Peak threads 30 29 -1

HEAD memory by 50-navigation quarter

HEAD range Avg RSS Final RSS Peak RSS Avg PSS Final PSS Peak FD
1–50 180.4 MiB 155.4 MiB 223.6 MiB 177.0 MiB 151.8 MiB 51
51–100 188.0 MiB 195.6 MiB 232.2 MiB 184.7 MiB 192.0 MiB 52
101–150 191.6 MiB 167.3 MiB 235.6 MiB 187.9 MiB 163.2 MiB 53
151–200 198.8 MiB 197.4 MiB 237.9 MiB 195.2 MiB 194.2 MiB 53

Raw reports and per-navigation boundary samples: workflow run and full sequential-navigation-soak-results artifact.

Public-site timing and memory are observational. Use the A/B deltas and trend shape as evidence, not as a deterministic performance threshold.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Spider Bench A/B

✅ All benchmark browser service runs completed; results are informational.

Public HEAD: 184 / 240 rows; 38 / 48 sites produced rows; 10 unexpected empty sites.

✅ Deterministic fixture contract is clean.

Common ancestor 2b44a137ff1e → HEAD 0961868aa6c4; benchmark order: base-first; workflow: success.

Public 48-site run · informational

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 184 / 240 184 / 240 0 (0.00%)
Contract fill 76.67% 76.67% 0.00 pp (0.00%)
Sites with rows 38 / 48 38 / 48 0 (0.00%)
Sites meeting row contract 36 / 48 36 / 48 0 (0.00%)
Unexpected empty sites 10 10 0 (0.00%)
Partial-row sites 2 2 0 (0.00%)
Site outcomes extracted: 36; HTTP error + rows: 2; empty: 7; HTTP error + empty: 1; snapshot error + empty: 2 extracted: 37; HTTP error + rows: 1; empty: 7; HTTP error + empty: 1; snapshot error + empty: 2 —
Observed duration 50.04 s 41.66 s -8.39 s (-16.76%)
Estimated CPU 42.80 s 38.64 s -4.15 s (-9.70%)
Peak PSS 198.01 MiB 265.16 MiB +67.15 MiB (+33.91%)
Peak RSS 201.67 MiB 279.07 MiB +77.40 MiB (+38.38%)
Peak threads 26 27 +1 (+3.85%)
Mismatched sites 0 0 0
Timeout with items 0 0 0
Category rows Base HEAD Δ
news 35 / 40 35 / 40 0
stocks 20 / 40 20 / 40 0
tech 35 / 40 35 / 40 0
sports 27 / 40 27 / 40 0
games 37 / 40 37 / 40 0
life 30 / 40 30 / 40 0

Public-site content, timing, and memory are noisy. This single A/B run reports evidence only; site outcome counts explain missing rows without treating them as a deterministic regression.

CPU and memory timelines

These are bounded 40-point views of the same complete process-tree samples used by the HTML report. CPU uses 100% per occupied logical core; memory lines are RSS first and PSS second when complete PSS samples are available.

Base

xychart-beta
    title "Base CPU"
    x-axis "Elapsed seconds" [1.536, 2.537, 3.038, 4.04, 5.541, 7.042, 8.542, 9.545, 11.048, 12.551, 14.052, 15.555, 16.557, 17.558, 18.058, 19.558, 21.058, 22.059, 23.56, 25.06, 26.563, 28.063, 29.065, 30.567, 32.069, 33.571, 34.572, 36.072, 37.575, 39.077, 40.578, 41.58, 43.082, 44.584, 46.086, 47.087, 48.59, 49.591]
    y-axis "CPU percent" 0 --> 200
    line [127.84, 101.88, 105.88, 95.88, 121.8, 93.96, 127.94, 61.87, 131.75, 31.93, 124.05, 3.99, 15.97, 0, 4, 2, 40.01, 125.86, 113.91, 121.94, 117.84, 102.01, 125.78, 121.68, 131.61, 109.71, 105.98, 23.99, 103.83, 45.99, 37.98, 117.69, 99.8, 99.89, 101.87, 135.83, 119.82, 155.86]
Loading
xychart-beta
    title "Base memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.034, 1.536, 2.537, 3.038, 4.04, 5.541, 7.042, 8.542, 9.545, 11.048, 12.551, 14.052, 15.555, 16.557, 17.558, 18.058, 19.558, 21.058, 22.059, 23.56, 25.06, 26.563, 28.063, 29.065, 30.567, 32.069, 33.571, 34.572, 36.072, 37.575, 39.077, 40.578, 41.58, 43.082, 44.584, 46.086, 47.087, 48.59, 49.591, 50.044]
    y-axis "Memory MiB" 0 --> 500
    line [13.11, 98.64, 107.23, 120.95, 119.71, 156.52, 129.75, 166.5, 140.78, 139.15, 130.83, 141.11, 115.93, 123.01, 121.09, 119.91, 119.98, 119.92, 150.29, 133.02, 193.97, 171.55, 201.67, 165.96, 138.02, 147.12, 146.46, 144.2, 139.31, 200.2, 144.38, 141.23, 169.57, 169.88, 169.89, 168.64, 141.29, 155.25, 173.59, 0]
    line [9.73, 95.12, 103.55, 117.54, 116.15, 152.97, 126.67, 156.11, 130.21, 136.07, 127.15, 136.4, 112.33, 119.41, 117.41, 116.24, 116.3, 116.25, 146.62, 129.43, 190.34, 167.88, 198.01, 162.35, 134.34, 143.52, 142.79, 140.52, 135.73, 196.57, 140.78, 137.52, 165.8, 166.11, 166.12, 164.9, 137.53, 151.6, 169.88, 0]
Loading

HEAD

xychart-beta
    title "HEAD CPU"
    x-axis "Elapsed seconds" [1.034, 2.035, 2.536, 3.537, 4.538, 6.04, 7.042, 8.044, 9.546, 10.548, 11.55, 13.051, 14.053, 15.054, 16.556, 17.557, 18.559, 20.059, 21.061, 21.561, 22.061, 23.563, 24.565, 25.566, 27.068, 28.069, 29.07, 30.572, 31.574, 32.576, 34.079, 35.081, 36.082, 37.583, 38.585, 39.085, 39.586, 41.087]
    y-axis "CPU percent" 0 --> 200
    line [25.98, 85.91, 115.78, 104, 149.92, 143.7, 149.78, 103.78, 115.72, 125.79, 85.81, 93.85, 67.84, 6, 0, 107.85, 57.87, 122, 99.9, 103.87, 114.08, 111.81, 121.81, 41.99, 115.88, 117.91, 101.98, 55.98, 55.87, 111.87, 121.72, 115.77, 2, 123.86, 99.88, 165.93, 9.97, 123.87]
Loading
xychart-beta
    title "HEAD memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.034, 1.034, 2.035, 2.536, 3.537, 4.538, 6.04, 7.042, 8.044, 9.546, 10.548, 11.55, 13.051, 14.053, 15.054, 16.556, 17.557, 18.559, 20.059, 21.061, 21.561, 22.061, 23.563, 24.565, 25.566, 27.068, 28.069, 29.07, 30.572, 31.574, 32.576, 34.079, 35.081, 36.082, 37.583, 38.585, 39.085, 39.586, 41.087, 41.655]
    y-axis "Memory MiB" 0 --> 500
    line [13.26, 83.55, 109.24, 108.46, 123.73, 132.56, 146.88, 151.1, 138.16, 134.84, 148.06, 117.64, 135.5, 143.41, 115.86, 121.14, 157.21, 157.93, 139.6, 239.61, 279.07, 177.96, 196.05, 221.38, 141.86, 186.04, 158.12, 142.23, 140.25, 143.15, 216.06, 227.45, 160.14, 131.36, 162.61, 169.07, 145.75, 145.93, 158.84, 0]
    line [9.83, 79.98, 105.62, 104.71, 120.23, 128.9, 143.28, 147.6, 134.44, 131.12, 144.28, 114.02, 131.55, 140.22, 112.33, 117.61, 154.18, 154.8, 135.99, 236.12, 265.16, 175.06, 192.59, 217.98, 138.36, 182.44, 154.6, 138.78, 136.73, 139.63, 212.98, 223.95, 156.62, 127.84, 158.28, 165.55, 142.23, 142.6, 155.35, 0]
Loading

Deterministic fixture · required contract

The fixture exercises 15 routes: 8 are expected to emit rows and 7 intentionally exercise empty, loading, or timeout behavior.

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 40 / 40 40 / 40 0 (0.00%)
Contract fill 100.00% 100.00% 0.00 pp (0.00%)
Sites with rows 8 / 15 8 / 15 0 (0.00%)
Sites meeting row contract 15 / 15 15 / 15 0 (0.00%)
Unexpected empty sites 0 0 0
Partial-row sites 0 0 0
Site outcomes extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 —
Observed duration 19.85 s 19.87 s +0.02 s (+0.10%)
Estimated CPU 0.40 s 0.46 s +0.06 s (+14.68%)
Peak PSS 65.79 MiB 66.85 MiB +1.05 MiB (+1.60%)
Peak RSS 69.20 MiB 70.46 MiB +1.26 MiB (+1.82%)
Peak threads 18 18 0 (0.00%)
Mismatched sites 0 0 0
Timeout with items 0 0 0

Full HTML, JSON, CSV, logs, and page snapshots: workflow run and full spider-bench-results artifact.

The public-web A/B is informational. The exact HEAD fixture contract runs as a separate required CI check; timing and public-site content deltas remain non-blocking.

@ldm0
ldm0 force-pushed the wpt/20261022-fullscreen-native-bindings branch from 2e78985 to 0961868 Compare October 22, 2026 09:36
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

CI Regression Report

Source CI run · source state at render: in_progress · artifacts: 6/6

Check Status Signal
Release regression ✅ HEAD/base failures 0/0; raw binary +0.009056%
Frontend differential ✅ 1,020/1,020 cases matched; 0 issues
Agent episodes ✅ 8/8 Moli episodes passed; 0 failures
Runtime/CDP contracts ✅ 26 contract cases; 0 failures
CDP smoke ✅ 52/52 groups passed; 622 scenarios
WebMainBench ✅ 545/545 completed; 0 unexpected failures
Release regression — ✅ HEAD/base failures 0/0; raw binary +0.009056%

Package and image size

Metric Base HEAD Delta Delta %
Raw binary 150.20 MiB 150.22 MiB +13.93 KiB +0.009056%
Stripped binary 103.28 MiB 103.29 MiB +12.00 KiB +0.011346%
gzip binary 51.58 MiB 51.59 MiB +2.48 KiB +0.004703%
Rootfs 157.11 MiB 157.12 MiB +10.00 KiB +0.006216%
gzip rootfs 60.49 MiB 60.49 MiB +3.06 KiB +0.004947%

Startup latency and PSS

Case Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta
Serve ready 26.93 ms 27.01 ms +0.08 ms 4.61 MiB 5.25 MiB +657.50 KiB
CDP first page 50.86 ms 49.23 ms −1.64 ms 4.62 MiB 4.44 MiB −188.50 KiB
CDP warm page 13.08 ms 12.23 ms −0.85 ms 49.87 MiB 50.75 MiB +896.00 KiB
CLI about:blank 15.62 ms 14.80 ms −0.82 ms 4.34 MiB 3.71 MiB −641.00 KiB
CLI local JS 18.84 ms 19.96 ms +1.12 ms 4.34 MiB 4.68 MiB +350.50 KiB

Concurrency matrix

Concurrency Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta HEAD failures Unstable B/H
1 18.31 ms 18.51 ms +0.20 ms 748.00 KiB 864.00 KiB +116.00 KiB 0 0/0
5 21.59 ms 21.22 ms −0.37 ms 13.33 MiB 28.15 MiB +14.82 MiB 0 0/0
10 21.22 ms 21.53 ms +0.32 ms 27.98 MiB 13.02 MiB −14.96 MiB 0 0/0
25 21.26 ms 21.90 ms +0.63 ms 13.26 MiB 23.43 MiB +10.17 MiB 0 0/0
100 22.16 ms 21.81 ms −0.35 ms 28.00 MiB 27.71 MiB −294.50 KiB 0 0/0
Frontend differential — ✅ 1,020/1,020 cases matched; 0 issues
Match DOM mismatch Diagnostic mismatch Moli error Reference error Infrastructure error Mismatched frames Duration
1,020 0 0 0 0 0 0 6m 28.90s
Agent episodes · Moli vs Chromium — ✅ 8/8 Moli episodes passed; 0 failures
Fast contract Episodes Passed Assertions Ready p50 Episode p50
Moli 8 8 47/47 2.87 ms 26.10 ms
Chromium 8 8 47/47 273.91 ms 89.59 ms
Operation p50 Chromium Moli Delta Delta %
navigate 40.44 ms 5.98 ms −34.46 ms −85.20%
observe 1.06 ms 1.04 ms −0.02 ms −2.32%
fill 4.14 ms 3.48 ms −0.66 ms −15.89%
click 6.21 ms 4.34 ms −1.87 ms −30.12%
Idle-resource episode Peak RSS Peak PSS Average CPU Peak CPU Peak processes Sampler
Moli 66.38 MiB 62.64 MiB 0.72% 8.04% 1 ✅
Chromium 1284.64 MiB 331.27 MiB 0.67% 11.94% 13 ✅
Runtime and CDP session contracts — ✅ 26 contract cases; 0 failures
Suite Cases Failures Median case p50 Median case p95 Median peak PSS p50
Synthetic fetch 13 0 18.46 ms 19.29 ms 812.00 KiB
Long-lived CDP session 13 0 18.15 ms 18.97 ms —
CDP smoke — ✅ 52/52 groups passed; 622 scenarios

Workers: 4 · cumulative group time: 198.43 s · failed groups: 0

Slowest group Scenarios Duration Status
scrollbar-visibility 22 29.14 s ✅
target-lifecycle 24 16.76 s ✅
dom-input 27 12.97 s ✅
chromium-cdp 56 11.75 s ✅
multi-page 45 11.30 s ✅
WebMainBench · 545 pages — ✅ 545/545 completed; 0 unexpected failures
Completed Successful Expected DNS failure Unexpected failures Panics Crashes Timeouts Empty output
545/545 544 1 0 0 0 0 0

Frozen HTML · Linux · --wait done · 45 seconds per page · no retries. Content quality is evaluated separately.

Diagnostics: webmainbench-results — every page's Markdown, stderr, and exit status. Source run and artifacts

All artifact fields are parsed by the trusted default-branch renderer; missing or invalid inputs remain visible as unavailable.

@ldm0
ldm0 added this pull request to stack #1882 October 22, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant