Skip to content

fix(dom): bind ParentNode members to their owning interfaces - #1866

Open
ldm0 wants to merge 1 commit into
wpt/20261022-node-native-proxy-backingfrom
wpt/20261022-parent-node-owning-interfaces
Open

fix(dom): bind ParentNode members to their owning interfaces#1866
ldm0 wants to merge 1 commit into
wpt/20261022-node-native-proxy-backingfrom
wpt/20261022-parent-node-owning-interfaces

Conversation

@ldm0

@ldm0 ldm0 commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

ParentNode mixin operations now validate the concrete interface that owns each prototype binding: Element, Document or DocumentFragment. Remove detached per-object/mixin overrides and share the native prototype operations, retaining registered native Proxy backing identity and owner-realm query results.

Regression coverage checks descriptors, invalid receivers before conversion, cross-realm operations, native aliases and live/windowless tree behavior.

Depends on #1861.

Validation on base cdb102cdc607: cargo fmt --all; cargo clippy --workspace --all-targets --all-features -- -D warnings; cargo nextest run --no-fail-fast. All passed (20,531 passed, 18 existing skips; 32 build jobs and test threads, no automatic retries). Focused regressions also passed.

@github-actions

github-actions Bot commented Oct 22, 2026

Copy link
Copy Markdown

Sequential Navigation Soak A/B

✅ HEAD completed the 200-navigation resilience and memory observation.

One browser process, one target, and one CDP session navigate CSDN → SegmentFault → Huaban → example.com repeatedly. This run issued 200 Page.navigate commands per binary.

Common ancestor 5c1e9eaff5 → HEAD 7a4d46dcec; benchmark order: head-first; workflow: success.

Session resilience

Metric Base HEAD
Attempted / planned 200 / 200 200 / 200
Direct observable pass 198 / 200 199 / 200
Failures / recovered 2 / 2 1 / 1
Recovery failures 0 0
Lifecycle order violations 0 0
Network order violations 0 0
Wall time 499.0 s 529.5 s

A public-page failure is reported separately from an unrecoverable session. The soak requires all navigation attempts, zero failed recovery, zero lifecycle/network ordering violations, and complete resource evidence.

Process-tree memory

Metric Base HEAD Δ
Boundary samples 200 200 0
Boundary RSS samples 200 200 0
Boundary PSS samples 200 200 0
Periodic peak RSS 243.5 MiB 246.0 MiB +2.6 MiB
Periodic peak PSS 241.7 MiB 242.6 MiB +0.8 MiB
RSS · first 10 avg 177.7 MiB 180.1 MiB +2.4 MiB
RSS · last 10 avg 199.5 MiB 198.8 MiB -0.7 MiB
RSS · last − first window +21.9 MiB +18.7 MiB -3.2 MiB
RSS · warm slope / 100 nav +13.7 MiB +12.4 MiB -1.3 MiB
PSS · first 10 avg 174.2 MiB 176.6 MiB +2.4 MiB
PSS · last 10 avg 197.2 MiB 195.3 MiB -1.8 MiB
PSS · last − first window +22.9 MiB +18.7 MiB -4.2 MiB
PSS · warm slope / 100 nav +14.7 MiB +12.3 MiB -2.4 MiB
Peak file descriptors 59 59 0
Peak threads 31 29 -2

HEAD memory by 50-navigation quarter

HEAD range Avg RSS Final RSS Peak RSS Avg PSS Final PSS Peak FD
1–50 175.7 MiB 154.4 MiB 214.7 MiB 172.2 MiB 150.8 MiB 52
51–100 185.9 MiB 221.4 MiB 230.4 MiB 182.5 MiB 217.9 MiB 52
101–150 199.3 MiB 167.5 MiB 231.8 MiB 195.5 MiB 163.9 MiB 52
151–200 197.2 MiB 186.7 MiB 236.6 MiB 193.6 MiB 183.2 MiB 52

Raw reports and per-navigation boundary samples: workflow run and full sequential-navigation-soak-results artifact.

Public-site timing and memory are observational. Use the A/B deltas and trend shape as evidence, not as a deterministic performance threshold.

@github-actions

github-actions Bot commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Spider Bench A/B

✅ All benchmark browser service runs completed; results are informational.

Public HEAD: 184 / 240 rows; 38 / 48 sites produced rows; 10 unexpected empty sites.

✅ Deterministic fixture contract is clean.

Common ancestor 5c1e9eaff57f → HEAD 7a4d46dcece1; benchmark order: head-first; workflow: success.

Public 48-site run · informational

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 184 / 240 184 / 240 0 (0.00%)
Contract fill 76.67% 76.67% 0.00 pp (0.00%)
Sites with rows 38 / 48 38 / 48 0 (0.00%)
Sites meeting row contract 36 / 48 36 / 48 0 (0.00%)
Unexpected empty sites 10 10 0 (0.00%)
Partial-row sites 2 2 0 (0.00%)
Site outcomes extracted: 37; HTTP error + rows: 1; empty: 7; HTTP error + empty: 1; snapshot error + empty: 2 extracted: 36; HTTP error + rows: 2; empty: 7; HTTP error + empty: 1; snapshot error + empty: 2 —
Observed duration 77.99 s 59.54 s -18.46 s (-23.66%)
Estimated CPU 47.26 s 47.35 s +0.09 s (+0.20%)
Peak PSS 263.07 MiB 232.93 MiB -30.14 MiB (-11.46%)
Peak RSS 267.76 MiB 237.17 MiB -30.59 MiB (-11.42%)
Peak threads 25 26 +1 (+4.00%)
Mismatched sites 0 0 0
Timeout with items 0 0 0
Category rows Base HEAD Δ
news 35 / 40 35 / 40 0
stocks 20 / 40 20 / 40 0
tech 35 / 40 35 / 40 0
sports 27 / 40 27 / 40 0
games 37 / 40 37 / 40 0
life 30 / 40 30 / 40 0

Public-site content, timing, and memory are noisy. This single A/B run reports evidence only; site outcome counts explain missing rows without treating them as a deterministic regression.

CPU and memory timelines

These are bounded 40-point views of the same complete process-tree samples used by the HTML report. CPU uses 100% per occupied logical core; memory lines are RSS first and PSS second when complete PSS samples are available.

Base

xychart-beta
    title "Base CPU"
    x-axis "Elapsed seconds" [2.037, 4.541, 5.042, 6.544, 8.547, 11.049, 13.051, 15.052, 17.555, 19.558, 21.557, 22.559, 24.06, 26.063, 28.066, 30.569, 32.572, 34.573, 36.074, 37.075, 39.078, 41.08, 43.585, 45.587, 47.591, 50.094, 52.097, 54.1, 56.603, 58.605, 60.608, 63.112, 65.115, 67.117, 69.62, 71.623, 73.626, 76.129]
    y-axis "CPU percent" 0 --> 200
    line [29.92, 11.99, 0, 27.95, 113.83, 2, 2, 63.94, 147.83, 130, 116.09, 155.83, 18, 107.8, 2, 5.99, 15.99, 105.96, 112.01, 105.85, 45.89, 121.88, 101.72, 145.67, 145.91, 45.88, 55.94, 1.99, 23.97, 21.98, 23.99, 0, 67.95, 0, 99.89, 99.85, 125.82, 25.98]
Loading 
xychart-beta
    title "Base memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.035, 2.037, 4.541, 5.042, 6.544, 8.547, 11.049, 13.051, 15.052, 17.555, 19.558, 21.557, 22.559, 24.06, 26.063, 28.066, 30.569, 32.572, 34.573, 36.074, 37.075, 39.078, 41.08, 43.585, 45.587, 47.591, 50.094, 52.097, 54.1, 56.603, 58.605, 60.608, 63.112, 65.115, 67.117, 69.62, 71.623, 73.626, 76.129, 77.995]
    y-axis "Memory MiB" 0 --> 500
    line [12.97, 99.24, 88.67, 88.68, 102.44, 106.04, 87.2, 88.94, 103.02, 141.5, 134.95, 133.39, 142.06, 120.59, 150.91, 115.95, 120.94, 116.76, 142.77, 267.76, 183.79, 138.18, 147.03, 150.59, 189.14, 222.04, 232.48, 229.61, 224.95, 224.8, 224.79, 224.77, 224.77, 245.07, 128.09, 171.85, 172.08, 162.14, 140.01, 0]
    line [9.69, 95.81, 85.24, 85.25, 99.01, 102.46, 83.76, 85.51, 99.59, 138.09, 131.52, 130.07, 138.58, 117.13, 147.58, 112.51, 117.61, 113.31, 139.33, 263.07, 180.35, 134.77, 143.87, 147.32, 185.67, 218.54, 229.03, 226.17, 221.5, 221.38, 221.36, 221.34, 221.35, 241.65, 124.67, 168.43, 168.66, 158.72, 136.61, 0]
Loading

HEAD

xychart-beta
    title "HEAD CPU"
    x-axis "Elapsed seconds" [1.54, 3.543, 5.045, 6.046, 7.048, 8.55, 10.051, 12.053, 13.556, 15.56, 17.061, 18.562, 20.565, 22.068, 24.071, 25.573, 27.075, 29.077, 30.58, 32.582, 34.084, 35.587, 37.59, 39.093, 40.094, 41.095, 42.597, 44.099, 46.102, 46.602, 47.604, 49.608, 51.11, 52.611, 54.614, 56.115, 58.117, 58.618]
    y-axis "CPU percent" 0 --> 200
    line [121.86, 121.83, 101.86, 0, 2, 25.95, 49.93, 125.98, 151.72, 75.83, 124, 111.96, 2, 23.94, 143.82, 73.88, 127.8, 135.59, 143.76, 123.9, 123.95, 81.83, 13.99, 121.75, 101.94, 30, 111.92, 0, 2, 109.93, 93.8, 109.83, 99.88, 98.02, 119.87, 149.82, 137.86, 151.73]
Loading 
xychart-beta
    title "HEAD memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.038, 1.54, 3.543, 5.045, 6.046, 7.048, 8.55, 10.051, 12.053, 13.556, 15.56, 17.061, 18.562, 20.565, 22.068, 24.071, 25.573, 27.075, 29.077, 30.58, 32.582, 34.084, 35.587, 37.59, 39.093, 40.094, 41.095, 42.597, 44.099, 46.102, 46.602, 47.604, 49.608, 51.11, 52.611, 54.614, 56.115, 58.117, 58.618, 59.539]
    y-axis "Memory MiB" 0 --> 500
    line [13.04, 98.17, 105.66, 118.77, 108.67, 94.05, 103.04, 115.76, 142.66, 135.04, 132.58, 154.43, 151.18, 130.24, 119.32, 137.68, 131.23, 180.89, 180.54, 192.87, 136.09, 153.05, 138.13, 136.08, 211.59, 237.17, 219.94, 225.7, 223.63, 225.14, 236.68, 150.09, 139.23, 172.4, 172.59, 161.21, 145.86, 158.93, 173.73, 0]
    line [9.58, 94.47, 102, 115.11, 104.98, 90.35, 99.35, 112.09, 138.89, 131.29, 128.83, 150.65, 147.41, 126.27, 115.54, 133.95, 127.54, 177.13, 176.86, 188.75, 133.86, 147.51, 134.36, 132.36, 208.1, 231.4, 216.3, 218.77, 219.99, 221.38, 232.93, 146.46, 135.6, 168.79, 168.96, 158.36, 142.21, 155.54, 170.11, 0]
Loading

Deterministic fixture · required contract

The fixture exercises 15 routes: 8 are expected to emit rows and 7 intentionally exercise empty, loading, or timeout behavior.

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 40 / 40 40 / 40 0 (0.00%)
Contract fill 100.00% 100.00% 0.00 pp (0.00%)
Sites with rows 8 / 15 8 / 15 0 (0.00%)
Sites meeting row contract 15 / 15 15 / 15 0 (0.00%)
Unexpected empty sites 0 0 0
Partial-row sites 0 0 0
Site outcomes extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 —
Observed duration 19.87 s 19.86 s -0.01 s (-0.05%)
Estimated CPU 0.48 s 0.44 s -0.04 s (-7.90%)
Peak PSS 66.07 MiB 66.05 MiB -0.02 MiB (-0.03%)
Peak RSS 69.45 MiB 69.60 MiB +0.15 MiB (+0.22%)
Peak threads 18 18 0 (0.00%)
Mismatched sites 0 0 0
Timeout with items 0 0 0

Full HTML, JSON, CSV, logs, and page snapshots: workflow run and full spider-bench-results artifact.

The public-web A/B is informational. The exact HEAD fixture contract runs as a separate required CI check; timing and public-site content deltas remain non-blocking.

@github-actions

github-actions Bot commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown

CI Regression Report

Source CI run · source state at render: in_progress · artifacts: 6/6

Check Status Signal
Release regression ✅ HEAD/base failures 0/0; raw binary −0.002098%
Frontend differential ✅ 1,020/1,020 cases matched; 0 issues
Agent episodes ✅ 8/8 Moli episodes passed; 0 failures
Runtime/CDP contracts ✅ 26 contract cases; 0 failures
CDP smoke ❌ 51/52 groups passed; 586 scenarios
WebMainBench ✅ 545/545 completed; 0 unexpected failures
Release regression — ✅ HEAD/base failures 0/0; raw binary −0.002098%

Package and image size

Metric Base HEAD Delta Delta %
Raw binary 150.20 MiB 150.20 MiB −3.23 KiB −0.002098%
Stripped binary 103.28 MiB 103.27 MiB −4.00 KiB −0.003782%
gzip binary 51.58 MiB 51.58 MiB −2.46 KiB −0.004651%
Rootfs 157.10 MiB 157.10 MiB 0 B 0.00%
gzip rootfs 60.49 MiB 60.49 MiB −1.26 KiB −0.002031%

Startup latency and PSS

Case Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta
Serve ready 26.79 ms 26.83 ms +0.04 ms 5.14 MiB 4.77 MiB −380.50 KiB
CDP first page 48.92 ms 48.49 ms −0.43 ms 5.00 MiB 3.89 MiB −1.11 MiB
CDP warm page 11.49 ms 12.21 ms +0.72 ms 50.44 MiB 50.48 MiB +34.00 KiB
CLI about:blank 15.07 ms 14.37 ms −0.70 ms 3.52 MiB 4.71 MiB +1.19 MiB
CLI local JS 18.83 ms 19.93 ms +1.10 ms 4.39 MiB 3.98 MiB −413.50 KiB

Concurrency matrix

Concurrency Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta HEAD failures Unstable B/H
1 18.73 ms 19.06 ms +0.32 ms 902.00 KiB 1.20 MiB +331.00 KiB 0 0/0
5 20.58 ms 23.28 ms +2.70 ms 13.62 MiB 24.05 MiB +10.44 MiB 0 0/0
10 20.99 ms 20.89 ms −0.11 ms 28.79 MiB 13.92 MiB −14.88 MiB 0 0/0
25 21.95 ms 21.52 ms −0.43 ms 13.74 MiB 23.83 MiB +10.10 MiB 0 0/0
100 20.55 ms 22.22 ms +1.67 ms 13.92 MiB 13.89 MiB −31.00 KiB 0 0/0
Frontend differential — ✅ 1,020/1,020 cases matched; 0 issues
Match DOM mismatch Diagnostic mismatch Moli error Reference error Infrastructure error Mismatched frames Duration
1,020 0 0 0 0 0 0 6m 35.75s
Agent episodes · Moli vs Chromium — ✅ 8/8 Moli episodes passed; 0 failures
Fast contract Episodes Passed Assertions Ready p50 Episode p50
Moli 8 8 47/47 3.00 ms 28.63 ms
Chromium 8 8 47/47 280.60 ms 95.21 ms
Operation p50 Chromium Moli Delta Delta %
navigate 48.62 ms 7.28 ms −41.34 ms −85.03%
observe 0.92 ms 1.35 ms +0.43 ms +46.25%
fill 4.29 ms 4.16 ms −0.13 ms −2.96%
click 6.24 ms 4.85 ms −1.39 ms −22.28%
Idle-resource episode Peak RSS Peak PSS Average CPU Peak CPU Peak processes Sampler
Moli 66.03 MiB 63.35 MiB 0.80% 10.04% 1 ✅
Chromium 1282.31 MiB 391.18 MiB 0.63% 10.00% 13 ⚠️ PSS partial
Runtime and CDP session contracts — ✅ 26 contract cases; 0 failures
Suite Cases Failures Median case p50 Median case p95 Median peak PSS p50
Synthetic fetch 13 0 19.55 ms 20.30 ms 829.00 KiB
Long-lived CDP session 13 0 17.99 ms 18.56 ms —
CDP smoke — ❌ 51/52 groups passed; 586 scenarios

Workers: 4 · cumulative group time: 185.02 s · failed groups: 1

Slowest group Scenarios Duration Status
scrollbar-visibility 22 28.11 s ✅
target-lifecycle 24 16.55 s ✅
dom-input 27 12.28 s ✅
multi-page 45 11.00 s ✅
layout-screenshot 5 8.45 s ✅

Failed groups

  • chromium-cdp — failed · Traceback (most recent call last): File "/__w/moli/moli/moli-cdp-smoke/moli_cdp_smoke/runner.py", line 754, in async_main await run_smoke(endpoint, fixtur
WebMainBench · 545 pages — ✅ 545/545 completed; 0 unexpected failures
Completed Successful Expected DNS failure Unexpected failures Panics Crashes Timeouts Empty output
545/545 544 1 0 0 0 0 0

Frozen HTML · Linux · --wait done · 45 seconds per page · no retries. Content quality is evaluated separately.

Diagnostics: webmainbench-results — every page's Markdown, stderr, and exit status. Source run and artifacts

All artifact fields are parsed by the trusted default-branch renderer; missing or invalid inputs remain visible as unavailable.

@ldm0
ldm0 force-pushed the wpt/20261022-node-native-proxy-backing branch from 5c1e9ea to cdb102c Compare October 22, 2026 09:36
@ldm0
ldm0 force-pushed the wpt/20261022-parent-node-owning-interfaces branch from 7a4d46d to 4930318 Compare October 22, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ldm0