Repository navigation
Conversation
ldm0
added this pull request to stack #1874
October 22, 2026 06:31
ldm0
force-pushed
the
wpt/20261022-range-webidl-node-arguments
branch
from
October 22, 2026 09:36
e5da120 to
a195f10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Range operations currently validate and recover Node arguments separately in individual callbacks. Convert them through shared WebIDL argument declarations and native interface brands before range algorithms run. StaticRange initialization uses the same typed node/offset conversion path.
Read node types, parents, UTF-16 lengths and boundary ordering from native Node references instead of author-visible nodeType/parentNode/data properties. Registered native aliases resolve to the same backing identity.
Regression coverage checks required arguments, conversion order, original exceptions, cross-realm errors, author property overrides and genuine versus forged/proxy node values.
For example, isPointInRange({}, 0) now raises the binding TypeError instead of returning false for an invalid Node argument.
Includes the small shared native Node reference identity core consumed by these algorithms, with explicit tree/Attr/Range and registered-alias checks in the existing proxy matrix.
Depends on #1862.
Validation on base
859c6c259dd8: cargo fmt --all; cargo clippy --workspace --all-targets --all-features -- -D warnings; cargo nextest run --no-fail-fast. All passed (20,533 passed, 18 existing skips; 32 build jobs and test threads, no automatic retries). Focused regressions also passed.