Repository navigation
Conversation
A retained child's original SameObject getter captured undefined when its lazy surface had never been read. Returning that snapshot after retirement made Window.screen disappear when an iframe was removed before its first read. Use captured objects when present, and let the exact retained native global materialize an untouched surface in its original Realm. Retain receiver and cross-origin authorization. Cover cold Screen reads, identity and zero geometry. Fixes: 9f11881 (PR #1651) Validate this independent patch on main ce0781f: - cargo fmt --all - cargo clippy --workspace --all-targets --all-features -- -D warnings - cargo nextest run --no-fail-fast Summary [ 380.812s] 20434 tests run: 20434 passed, 18 skipped Original-commit: f202f5d
CI Regression ReportSource CI run · source state at render:
Release regression — ✅ HEAD/base failures 0/0; raw binary 0.00%Package and image size
Startup latency and PSS
Concurrency matrix
Frontend differential — ❌ 1,015/1,020 cases matched; 5 issues
First failing cases
Agent episodes · Moli vs Chromium — ⚪ artifact unavailable or invalidArtifact unavailable or invalid. See the source CI run for infrastructure details. Runtime and CDP session contracts — ✅ 26 contract cases; 0 failures
CDP smoke — ✅ 52/52 groups passed; 622 scenariosWorkers: 4 · cumulative group time: 170.19 s · failed groups: 0
WebMainBench · 545 pages — ✅ 545/545 completed; 0 unexpected failures
Frozen HTML · Linux · Diagnostics: All artifact fields are parsed by the trusted default-branch renderer; missing or invalid inputs remain visible as unavailable. |
Spider Bench A/B✅ All benchmark browser service runs completed; results are informational. Public HEAD: 184 / 240 rows; 38 / 48 sites produced rows; 10 unexpected empty sites. ✅ Deterministic fixture contract is clean. Common ancestor Public 48-site run · informational
Public-site content, timing, and memory are noisy. This single A/B run reports evidence only; site outcome counts explain missing rows without treating them as a deterministic regression. CPU and memory timelinesThese are bounded 40-point views of the same complete process-tree samples used by the HTML report. CPU uses 100% per occupied logical core; memory lines are RSS first and PSS second when complete PSS samples are available. Basexychart-beta
title "Base CPU"
x-axis "Elapsed seconds" [1.536, 3.039, 4.04, 4.541, 6.542, 8.044, 9.544, 11.044, 12.546, 14.048, 15.55, 17.555, 19.057, 20.558, 21.059, 22.062, 23.562, 24.063, 25.064, 26.567, 28.569, 30.07, 31.571, 33.071, 34.574, 36.077, 37.581, 39.084, 41.086, 42.587, 44.087, 45.587, 47.087, 48.59, 50.093, 52.097, 53.599, 55.102]
y-axis "CPU percent" 0 --> 200
line [2, 17.96, 0, 4, 106, 121.84, 129.98, 114.02, 129.78, 133.73, 67.87, 59.87, 21.97, 43.93, 157.71, 65.82, 109.96, 99.89, 109.86, 113.74, 129.61, 89.98, 71.93, 29.99, 99.84, 0, 3.99, 0, 0, 2, 2, 2, 0, 2, 81.86, 35.92, 111.96, 103.93]
xychart-beta
title "Base memory: RSS then PSS"
x-axis "Elapsed seconds" [0.036, 1.536, 3.039, 4.04, 4.541, 6.542, 8.044, 9.544, 11.044, 12.546, 14.048, 15.55, 17.555, 19.057, 20.558, 21.059, 22.062, 23.562, 24.063, 25.064, 26.567, 28.569, 30.07, 31.571, 33.071, 34.574, 36.077, 37.581, 39.084, 41.086, 42.587, 44.087, 45.587, 47.087, 48.59, 50.093, 52.097, 53.599, 55.102, 56.591]
y-axis "Memory MiB" 0 --> 500
line [13.64, 61.96, 90.91, 79.65, 79.83, 122.28, 147.03, 125.53, 145.57, 133.31, 142.22, 138.15, 144.96, 118.13, 131.61, 149.28, 124.71, 159.93, 233.96, 175.57, 207.18, 164.86, 157.34, 146.91, 136.48, 131.21, 129.82, 128.13, 128.13, 128.13, 128.13, 128.13, 128.13, 128.13, 128.13, 145.61, 140.11, 155.77, 139.15, 0]
line [10.34, 58.53, 87.48, 76.21, 76.45, 118.89, 143.59, 122.3, 141.94, 129.71, 139.17, 134.6, 141.41, 114.6, 128.09, 145.83, 121.16, 156.38, 230.43, 172.01, 203.66, 160.75, 153.92, 143.47, 133.23, 127.97, 126.58, 124.89, 124.89, 124.71, 124.88, 124.88, 124.76, 124.76, 124.76, 142.25, 134.02, 152.4, 135.61, 0]
HEADxychart-beta
title "HEAD CPU"
x-axis "Elapsed seconds" [1.035, 1.536, 2.538, 4.04, 5.041, 6.544, 7.544, 9.046, 10.047, 11.547, 13.051, 14.051, 15.551, 16.551, 18.054, 18.555, 19.056, 20.557, 21.557, 23.06, 24.564, 25.064, 25.564, 27.066, 28.067, 29.569, 30.569, 32.072, 33.072, 34.575, 36.076, 37.078, 38.58, 39.58, 41.082, 42.084, 43.585, 44.585]
y-axis "CPU percent" 0 --> 200
line [2, 91.8, 4, 123.8, 85.89, 123.7, 145.98, 139.63, 99.98, 69.95, 129.74, 15.99, 6, 99.97, 41.91, 0, 5.99, 42.01, 93.93, 117.77, 109.75, 105.89, 113.94, 103.88, 129.76, 127.93, 99.9, 99.72, 73.94, 8, 95.82, 39.98, 3.99, 0, 85.97, 119.69, 14, 120]
xychart-beta
title "HEAD memory: RSS then PSS"
x-axis "Elapsed seconds" [0.035, 1.035, 1.536, 2.538, 4.04, 5.041, 6.544, 7.544, 9.046, 10.047, 11.547, 13.051, 14.051, 15.551, 16.551, 18.054, 18.555, 19.056, 20.557, 21.557, 23.06, 24.564, 25.064, 25.564, 27.066, 28.067, 29.569, 30.569, 32.072, 33.072, 34.575, 36.076, 37.078, 38.58, 39.58, 41.082, 42.084, 43.585, 44.585, 46.04]
y-axis "Memory MiB" 0 --> 500
line [13.56, 64.73, 89.89, 80.21, 129.74, 124.53, 140.41, 142.17, 147.8, 146.42, 134.45, 157.79, 141.47, 122.92, 146.8, 131.36, 131.64, 116.18, 129.84, 161.85, 141.51, 203.4, 258.89, 171.25, 190.66, 209.45, 153.71, 167.29, 132.84, 141.09, 127.81, 167.85, 129.89, 137.5, 125.45, 134.22, 150.88, 129.44, 145.78, 0]
line [10.37, 61.32, 86.71, 76.81, 126.59, 121.16, 137.01, 138.77, 144.52, 143.02, 131.06, 154.43, 138.04, 119.34, 143.21, 127.92, 128.2, 112.74, 126.31, 158.31, 138.01, 199.78, 249.21, 167.87, 187.2, 206, 150.9, 163.66, 129.28, 138.42, 124.25, 163.84, 126.33, 133.94, 121.89, 130.67, 147.32, 125.89, 143.22, 0]
Deterministic fixture · required contractThe fixture exercises 15 routes: 8 are expected to emit rows and 7 intentionally exercise empty, loading, or timeout behavior.
Full HTML, JSON, CSV, logs, and page snapshots: workflow run and full The public-web A/B is informational. The exact HEAD fixture contract runs as a separate required CI check; timing and public-site content deltas remain non-blocking. |
Sequential Navigation Soak A/B✅ HEAD completed the 200-navigation resilience and memory observation. One browser process, one target, and one CDP session navigate CSDN → SegmentFault → Huaban → example.com repeatedly. This run issued 200 Common ancestor Session resilience
A public-page failure is reported separately from an unrecoverable session. The soak requires all navigation attempts, zero failed recovery, zero lifecycle/network ordering violations, and complete resource evidence. Process-tree memory
HEAD memory by 50-navigation quarter
Raw reports and per-navigation boundary samples: workflow run and full Public-site timing and memory are observational. Use the A/B deltas and trend shape as evidence, not as a deterministic performance threshold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retaining an iframe Window and removing the frame before the first
screenread returnedundefined. Let the exact retained native global materialize an untouched lazy surface in its original Realm, while preserving native receiver checks, cross-origin authorization, captured objects, and SameObject identity.The regression coverage now includes cold Screen reads and detached geometry, plus first Navigator/Performance reads after removal. The added test confirms both instances remain unmaterialized until detach, checks the original Realm prototypes and Navigator alias identity, compares
Performance.timeOriginwith the native seed captured before detach, and ensures parent instances remain lazy.Fixes
9f11881c1a5c9a1715245da3294af719b1d1b467(#1651). This PR is independent of the other runtime splits from #1726.Validation on
d088b38371a:cargo fmt --allcargo clippy --workspace --all-targets --all-features -- -D warningscargo nextest run --no-fail-fast: 20,435 passed, 18 skipped, using default machine parallelism. The new cold Navigator/Performance test passed.The original frontend timeouts did not reproduce on unchanged production code: the CI rerun completed successfully, including 1,020/1,020 matched frontend cases. Earlier focused rechecks matched all five reported cases, and full parent/head artifact rechecks each matched 1,020 cases with identical Chromium timelines. This follow-up adds test coverage only; the production patch remains unchanged.
No aggregate Cases snapshot or documentation is included.