Repository navigation
test(indexeddb): isolate temporary directories across test processes - #1589
Merged
Merged
Conversation
lanyue-llk
force-pushed
the
codex/webfetch-test-isolation
branch
from
October 15, 2026 13:35
dd1697f to
725acf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Concurrent test processes restart their local sequence counter. Combining that counter with a timestamp did not guarantee separate temporary directories, and create_dir_all could silently reuse an existing directory.
Change
Include the process ID in the existing test-directory name and create the directory exclusively. Keep the current RAII cleanup and database test behavior.
Test fixtures only; production database paths and persistence semantics are unchanged.
Reproduce and verify
Run the existing IndexedDB suite with parallel nextest processes. Each fixture owns a separate directory, so deleting one test's data cannot remove another test's database.
Before extraction, this source passed
cargo fmt --all, workspace/all-target/all-feature Clippy with-D warnings, and the full workspace nextest suite (20,140 passed, 17 skipped). This unit has no source changes since that validation. The PR CI checks its extraction onto mainbe610b8fe.Regression fixtures:
upgrade_transaction_can_create_store_and_persistreadwrite_transaction_can_store_and_reload_recordsDependencies
Independent change targeting
main; no other open PR is required. Extracted from #1501. Review map and sibling PRs.