Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short navigation deadline could expire after the page had loaded because optional network-idle and render-grace waits consumed the time needed to read the document. This reproduced in the macOS real-Chromium integration test with its existing one-second action budget.
Both optional waits now share at most half of the remaining action budget. Layout and required document observation retain the remainder; the overall deadline and existing maximum wait durations are unchanged. Actual observation timeouts still fail.
This changes settling behavior for future short-budget replays, which can observe a page earlier. It does not edit or regenerate historical attempts, scores, or reports, and does not promise identical results for future reruns. It requires no Web Fetch report changes.
Validation:
28534e24, all 64 targeted tests pass, including the unchanged macOS real-Chromium test and six deterministic controls covering fast/idle/streaming networks and successful/timed-out observations.make ciand GitHub CI as commita5da00fdin Make Web Fetch method metadata reusable across versions and cohorts #59. This PR separates it for independent review; its independent GitHub CI run 39735061079 now passes at608c6e0d, including the complete main test job and Python 3.12/3.13/3.14 Base CLI checks. Optional Claude Review was skipped.Extracted from #59. No PR is merged by this change.