Repository navigation
Lightpanda: run the Selenium, Pydoll, chromedp and ferrum suites - #30
Merged
Merged
Conversation
Ferrum takes the default context of Lightpanda's placeholder target as its default context, and createTarget in it fails with UnknownBrowserContextId. For Lightpanda, new_page now creates one browser context and creates every page in it. Other engines keep browser.create_page.
Member
|
Thanks for the contribution! One remaining gap: Lightpanda lacks WebDriver These are not blockers for this PR. This PR LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋
I did some change to fix different issue of the bench w/ Lightpanda.
All changes are gated to Lightpanda, or to engines with the same behavior, so Chrome, Moli and Obscura keep their published paths.
Changes
--load-resources iframe --load-resources worker --protocol cdp --protocol webdriver, set inENGINE_DEFS["lightpanda"]["serve_args"].browserNameandbrowserVersionchecks now read each engine's expected values fromENGINE_DEFS[...]["webdriver_identity"].createTarget+attachToTarget(flatten=true)). The route is renamed frompydoll_obscura_cdptopydoll_empty_registry_cdp.new_pagereuses the root tab instead of opening a second target, which Lightpanda rejects withTargetAlreadyLoaded. Only Lightpanda takes this path (rootTabReuseEngines).BID-STARTUPcontext of Lightpanda's placeholder target as its default context, andcreateTargetin it fails withUnknownBrowserContextId. For Lightpanda,new_pagenow creates one browser context and creates every page in it (EXPLICIT_CONTEXT_ENGINES).1.1.0-nightly.10552+dd2cd5d7f