Catch errors from invalid macro while expanding#21
Open
JesperAxelsson wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Lem UI deadlock by catching compiler errors in macrostep-expand-1
When expanding a syntactically malformed macro,
macrostep-expand-1failsto catch low-level compiler errors. These uncaught errors bypass the local
error-messagecheck and trigger the interactive Swank/Micros debugger.Because the Lem UI thread is blocked synchronously waiting for an
(:ok ...)or(:error ...)response list, the editor deadlocks.This wraps the expansion step in
macrostep-expand-1with ahandler-caseensuring fatal compiler crashes are safely caught
and returned as standard
(:error ...)lists.How to recreate in lem
If you have a broken macro like this:
And try to expand it in a buffer with
lisp-macrostep-expandorC-c enter.Let me know if there anything you want to change/add.