Conversation
leblancfg
added this pull request to stack #220
September 19, 2026 12:56
leblancfg
removed this pull request from stack #220
September 19, 2026 17:14
leblancfg
force-pushed
the
issue-211-json-diagnostics
branch
from
September 19, 2026 17:14
526f9da to
9034633
Compare
leblancfg
added this pull request to stack #222
September 19, 2026 17:14
leblancfg
force-pushed
the
issue-211-json-diagnostics
branch
from
September 19, 2026 18:25
9034633 to
6af41f9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON/result layer above typing PR #221
Native stack #222, from master upward: #221 → #213 → #214 → #219. Review/merge bottom-up using GitHub's stack controls after approval and green CI. A group merge includes all lower unmerged PRs; GitHub rebases the remaining stack after a partial merge. Do not use the former reverse-order/manual-base-edit recipe.
Nothing has been merged, tagged, released, or published. The restack preserves the existing PRs and review discussions.
API introduced here
crop()always returnsCropResultwithimageand aCropDiagnosticsdataclass.image=Noneand a reason; unreadable inputs and invalid configuration still raise..imageand check that field for None. README, API/quickstart/overview, notebook, and tests reflect this contract; Prepare v2 migration FAQ and actionable compatibility errors #219 adds the full migration FAQ.Implementation
diagnostics.pycontains typed result records, independent of printing/file handling.reporting.pyowns CLI serialization, atomic writes, and source/output/redirected-stream alias safeguards.timing.py; alignment/migration modules arrive in their own PRs.Validation
Closes #211. SDK decisions #215–#218 remain for discussion before publication.
Toolchain sync
The ty/Ruff configuration, dependencies, recipes, and CI changes live in #221. This layer inherits them, uses Ruff formatting/import order, and updates consumer checks to ty-specific expected diagnostics. Local ty, Ruff lint/format, and all 118 tests pass. Runtime API and stack order are unchanged.