Fix preset lookup for base64 exercise images#670
Draft
rtibbles wants to merge 1 commit into
Draft
Conversation
_ExerciseBase64ImageFile inherited ThumbnailPresetMixin.get_preset via Base64ImageFile, which dereferences self.node — but exercise images are attached to a question, not a node. Mirror _ExerciseImageFile instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ExerciseBase64ImageFileinheritsThumbnailPresetMixin.get_presetviaBase64ImageFile, which dereferencesself.node— but exercise images are attached to a question, not a node, so callingget_preset()raisedAttributeError. Override it to return the exercise image preset, mirroring the sibling_ExerciseImageFile.References
Extracted from in-progress spreadsheet chef work; no linked issue.
Reviewer guidance
uv run --group test pytest tests/test_exercises.py— the new test was verified to fail withAttributeErrorbefore the fix.AI usage
I used Claude Code to extract this fix from a larger working branch and add the regression test; I reviewed the final diff.