Block external network access in Python tests#14809
Open
rtibbles wants to merge 1 commit into
Open
Conversation
The key urls walker test has been making real HTTP requests to the Kolibri Data Portal (via the portal validate_token proxy view) and to Studio (via the remote channel viewset) on every run since 2019, failing whenever those services have an outage. Patch socket.getaddrinfo and socket.socket.connect in conftest so any attempt to reach a non-loopback address raises a clear error naming the offending host, and mock the outbound requests in the key urls test at the requests session level. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
DEV: backend
Contributor
Build Artifacts
Smoke test screenshot |
rtibbles
force-pushed
the
block-network-in-tests
branch
from
598b60f to
1cd6ef5
Compare
rtibbles
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_tokenand remote channel views) — recent CI failures were KDP 521sReferences
Reviewer guidance
requests.getto a testAI usage
Written with Claude Code: it audited the suite for real network access by running it under a socket-level recording guard, then implemented the conftest guard. I reviewed the changes and verified the full suite passes locally with the network blocked.