Skip to content

Fix pipeline stage check and add tests #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aobolensk merged 4 commits into from
Jun 22, 2025
Merged

Fix pipeline stage check and add tests #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3561e14
fix: check pipeline size before adjacent_find
aobolensk Jun 20, 2025
ee7e7a4
Add nolint
aobolensk Jun 20, 2025
e1ead00
Remove NOLINTs
aobolensk Jun 22, 2025
d808d62
100
aobolensk Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions modules/core/task/include/task.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,12 +246,16 @@ class Task {
bool was_worked_ = false;

bool IsFullPipelineStage() {
if (functions_order_.size() < 4) {
return false;
}

auto it = std::adjacent_find(functions_order_.begin() + 2,
functions_order_.begin() + static_cast<long>(functions_order_.size() - 2),
std::not_equal_to<>());

return (functions_order_.size() >= 4 && functions_order_[0] == "Validation" &&
functions_order_[1] == "PreProcessing" && functions_order_[2] == "Run" &&
return (functions_order_[0] == "Validation" && functions_order_[1] == "PreProcessing" &&
functions_order_[2] == "Run" &&
it == (functions_order_.begin() + static_cast<long>(functions_order_.size() - 2)) &&
functions_order_[functions_order_.size() - 1] == "PostProcessing");
}
Expand Down
2 changes: 1 addition & 1 deletion modules/core/task/tests/.clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ Checks: >

CheckOptions:
- key: readability-function-cognitive-complexity.Threshold
value: 50 # default: 25
value: 100 # default: 25
19 changes: 19 additions & 0 deletions modules/core/task/tests/task_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,25 @@ TEST(task_tests, check_empty_order_disabled_valgrind) {
EXPECT_DEATH_IF_SUPPORTED(destroy_function(), ".*ORDER OF FUNCTIONS IS NOT RIGHT.*");
}

TEST(task_tests, premature_postprocessing_no_steps) {
auto destroy_function = [] {
std::vector<float> in(20, 1);
ppc::test::task::TestTask<std::vector<float>, float> test_task(in);
ASSERT_NO_THROW(test_task.PostProcessing());
};
EXPECT_DEATH_IF_SUPPORTED(destroy_function(), ".*ORDER OF FUNCTIONS IS NOT RIGHT.*");
}

TEST(task_tests, premature_postprocessing_after_preprocessing) {
auto destroy_function = [] {
std::vector<float> in(20, 1);
ppc::test::task::TestTask<std::vector<float>, float> test_task(in);
ASSERT_NO_THROW(test_task.PreProcessing());
ASSERT_NO_THROW(test_task.PostProcessing());
};
EXPECT_DEATH_IF_SUPPORTED(destroy_function(), ".*ORDER OF FUNCTIONS IS NOT RIGHT.*");
}

int main(int argc, char **argv) {
testing::InitGoogleTest(&argc, argv);
return RUN_ALL_TESTS();
Expand Down
Loading