Skip to content

Handle MPI init/finalize failures #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aobolensk merged 1 commit into from
Jun 20, 2025
Merged

Handle MPI init/finalize failures #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/core/runners/include/runners.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ class WorkerTestFailurePrinter : public ::testing::EmptyTestEventListener {
/// @brief Initializes the testing environment (e.g., MPI, logging).
/// @param argc Argument count.
/// @param argv Argument vector.
/// @return Exit code: 0 for success, non-zero for failure.
/// @return Exit code from RUN_ALL_TESTS or MPI error code if initialization/
/// finalization fails.
int Init(int argc, char** argv);

} // namespace ppc::core
14 changes: 12 additions & 2 deletions modules/core/runners/src/runners.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,12 @@ void WorkerTestFailurePrinter::PrintProcessRank() {
}

int Init(int argc, char** argv) {
MPI_Init(&argc, &argv);
const int init_res = MPI_Init(&argc, &argv);
if (init_res != MPI_SUCCESS) {
std::cerr << std::format("[ ERROR ] MPI_Init failed with code {}", init_res) << '\n';
MPI_Abort(MPI_COMM_WORLD, init_res);
return init_res;
}

// Limit the number of threads in TBB
tbb::global_control control(tbb::global_control::max_allowed_parallelism, ppc::util::GetNumThreads());
Expand All @@ -79,7 +84,12 @@ int Init(int argc, char** argv) {
listeners.Append(new ppc::core::UnreadMessagesDetector());
auto status = RUN_ALL_TESTS();

MPI_Finalize();
const int finalize_res = MPI_Finalize();
if (finalize_res != MPI_SUCCESS) {
std::cerr << std::format("[ ERROR ] MPI_Finalize failed with code {}", finalize_res) << '\n';
MPI_Abort(MPI_COMM_WORLD, finalize_res);
return finalize_res;
}
return status;
}

Expand Down
Loading