Skip to content

Make readability-function-cognitive-complexity threshold more strict#365

Merged
allnes merged 1 commit intolearning-process:masterfrom
aobolensk:strict-cognitive-complexity
Apr 14, 2025
Merged

Make readability-function-cognitive-complexity threshold more strict#365
allnes merged 1 commit intolearning-process:masterfrom
aobolensk:strict-cognitive-complexity

Conversation

@aobolensk
Copy link
Copy Markdown
Member

Functions with scores beyond 15 are typically flagged as potentially problematic. Empirical evidence suggests that such functions are more likely to correlate with higher error rates or maintenance challenges. It becomes increasingly hard for developers to follow the control flow, and these functions are prime candidates for refactoring into simpler, more modular parts.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • tasks/mpi/example/src/ops_mpi.cpp: Language not supported

Comment thread .clang-tidy
@allnes allnes enabled auto-merge April 14, 2025 11:23
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (7e9c38d) to head (7b9ac0a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   95.47%   96.50%   +1.03%     
==========================================
  Files          26       26              
  Lines         486      487       +1     
  Branches      145      143       -2     
==========================================
+ Hits          464      470       +6     
+ Misses          9        5       -4     
+ Partials       13       12       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@allnes allnes added this pull request to the merge queue Apr 14, 2025
Merged via the queue into learning-process:master with commit 3fb6776 Apr 14, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants