Make readability-function-cognitive-complexity threshold more strict#365
Merged
allnes merged 1 commit intolearning-process:masterfrom Apr 14, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 95.47% 96.50% +1.03%
==========================================
Files 26 26
Lines 486 487 +1
Branches 145 143 -2
==========================================
+ Hits 464 470 +6
+ Misses 9 5 -4
+ Partials 13 12 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
via the queue into
learning-process:master
with commit Apr 14, 2025
3fb6776
29 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions with scores beyond 15 are typically flagged as potentially problematic. Empirical evidence suggests that such functions are more likely to correlate with higher error rates or maintenance challenges. It becomes increasingly hard for developers to follow the control flow, and these functions are prime candidates for refactoring into simpler, more modular parts.