feat: resolve links and footnotes through document reconstruction - #1014
Merged
Merged
Conversation
Replaces type-class-based compilation of footnote and link labels references with a use of document reconstruction data at the end. This allows blocks to be compiled incrementally during elaboration instead of all at the end and makes it easier to produce good errors. Along the way, fixed some bugs in footnote resolution (especially recursive).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces type-class-based compilation of footnote and link labels references with a use of document reconstruction data at the end. This allows blocks to be compiled incrementally during elaboration instead of all at the end and makes it easier to produce good errors.
The LSP support for footnotes and labeled URLs now also uses as many snapshots as are currently available instead of waiting for the final snapshot.
Along the way, fixed some bugs in footnote resolution (especially recursive).