Feature/add native send keyboard enter #3044
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a sendKeyboardEnter method to MobileAutomator to simulate native keyboard enter actions, implemented for Android and stubbed for iOS. It also introduces a new E2E test and a sample screen with multiple text fields. PatrolTester.enterText was updated to unregister testTextInput and clear focus after entry, which is identified as a potential breaking change requiring documentation or configuration. Further feedback includes correcting a typo in the changelog and adding assertions to the new E2E test to verify that the onSubmitted callback is triggered.
|
Nitpick: I think we prefer to start commit messages with imperative form, e.g. "Fix typo" instead of "Fixed typo". Also we'd start with a capital letter. |
Issue #2748
Contents
Implements SendKeyboardEnter() function for mobile platform (currently only android waiting for #3003 to close) that sends Enter action for currently focused input. On android it uses native UiDevice.pressEnter().
Test plan
dev/e2e_app/patrol_test/mobile_keyboard_enter_test.dart- tests pressing enter on all available keyboard types on given device.CI
test android emulator webviewexpected to failpatrol_finders check semverexpected to fail