Fixes - #11796
Merged
Merged
Conversation
someaddons
commented
Aug 28, 2026
| for (final IColony colony : IColonyManager.getInstance().getAllColonies()) | ||
| { | ||
| if (colony.getPermissions().getRank(player).isColonyManager()) | ||
| if (colony.getWorld() != null && colony.getPermissions().getRank(player).isColonyManager()) |
Contributor
Author
There was a problem hiding this comment.
Since not all words are loaded from the get-go we cannot register to all colonies right away. Our existing dimension change hooks etc will take care of later registration
Raycoms
approved these changes
Aug 30, 2026
Raycoms
added a commit
that referenced
this pull request
Aug 30, 2026
genericJE
added a commit
to genericJE/minecolonies
that referenced
this pull request
Aug 31, 2026
The doc set was verified against 1e1b1d8 (origin/release/1.21, still its head). version/1.21 has since moved 7 commits: 6 .java files, 25 blueprints, 2 regenerated loot tables and one lang comment. Corrections: - Five raid config TOML keys were renamed in a8022f7 (ldtteam#11796) to match their fields. Fixed in the combat config table (00), the ServerConfiguration rows and prose in 06, and the tuning bullet in 14, with a note recording the old names and the fact that release/1.21 builds still use them. - RequestTreeWindowModule.java is 412 lines, not 407 (11). - WindowHutAllInventory inventoryHighlight moved to :123 / :140 (11). Every doc header now cites version/1.21 @ a8022f7. 21 records what was re-verified, what carried over unchanged, and the new upstream behaviour that is not yet folded into the set. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent crash when a colony is in a dynamically loaded world Fix config descriptions, using the wrong key.
Fix config description including default value twice. Prevent crash with the RequestTreeWindowModule with zero Requests left
Checklist
Related issues
Closes #11743
Closes #11793
Closes #11756
Changes proposed in this pull request
Review please