Nullness safety on RECIPE_MODE - #11784
Open
armele wants to merge 5 commits into
Open
Conversation
Raycoms
reviewed
Aug 13, 2026
| } | ||
| } | ||
|
|
||
| final CrafterRecipeSetting recipeMode = building.getSetting(RECIPE_MODE); |
Contributor
There was a problem hiding this comment.
this has to go inside the first if then =D
Contributor
Author
There was a problem hiding this comment.
No more code changes after midnight for me...
Raycoms
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Related issues
Closes - Error reported in Trade Post discord.
Symptom revealed with injected "Dairyworker" (Trade Post mod) module for the Cowhand, which turns that building into one which hosts a crafting job, but whose settings module does not include "RECIPE_MODE". This nullness check is safe, and "add-on friendly", giving some protection against add-ons which may have this scenario.
Changes proposed in this pull request
Review please