feat: add cost optimisation PR review playbook - #24
Open
LukeDolemanResDiary wants to merge 1 commit into
Open
Conversation
Add playbooks/review/cost-optimisation.md — a PR-level cost review companion to the existing assess/cost-optimisation.md assessment. The review playbook narrows the assessment scope to changes in a single PR, providing a checklist-driven evaluation across: - API & external calls (cache-first, polling, batching, short-circuit) - Data transfer (pagination, payload minimisation, compression) - Dependencies (stdlib duplication, package health, transitive graph) - Compute & resources (client initialisation, unbounded collections) - Observability (log verbosity, metric cardinality, trace sampling) - LLM token costs (output structure, metadata stripping, tool economy) - CI/CD (runner tier, dependency caching, stage ordering, path filtering) Also registers the new playbook in core/.context/index.md so keyword routing picks it up on 'review cost', 'FinOps audit', 'cost review', and 'resource optimisation'.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a PR-level cost optimisation review playbook and registers it for context routing.
Changes:
- Adds cost-focused review criteria and output guidance.
- Registers cost review keywords in the context index.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
playbooks/review/cost-optimisation.md |
Defines the cost optimisation review playbook. |
core/.context/index.md |
Routes cost review keywords to the playbook. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| | review compliance, compliance review | `.context/playbooks/review/compliance.md` | Data handling, encryption, audit compliance | | ||
| | review IaC, infrastructure review | `.context/playbooks/review/iac.md` | Infrastructure code patterns and security | | ||
| | review observability, observability review | `.context/playbooks/review/observability.md` | Logging, tracing, metrics instrumentation | | ||
| | review cost, FinOps audit, cost review, resource optimisation | `.context/playbooks/review/cost-optimisation.md` | API economy, dependencies, observability spend | |
|
|
||
| ## Scope | ||
|
|
||
| Review **only the changes in this PR**. Evaluate: |
|
|
||
| - **Cache before network** — Every read must check cache first | ||
| - **Bound every output** — No unbounded result sets | ||
| - **Measure what you spend** — `duration_ms` and `cache_hit` logging on expensive operations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add playbooks/review/cost-optimisation.md — a PR-level cost review companion to the existing assess/cost-optimisation.md assessment.
The review playbook narrows the assessment scope to changes in a single PR, providing a checklist-driven evaluation across:
Also registers the new playbook in core/.context/index.md so keyword routing picks it up on 'review cost', 'FinOps audit', 'cost review', and 'resource optimisation'.