[Bug] foundryvtt-module-scaffold: generated modules get a duplicate Renovate runner

[laurigates]

What

foundryvtt-module-scaffold emits .github/workflows/renovate.yml into every generated module:

• foundryvtt-plugin/skills/foundryvtt-module-scaffold/scaffold.py:543 (the RENOVATE_YML body, name: Renovate, calling laurigates/.github/.github/workflows/reusable-renovate.yml@main)
• foundryvtt-plugin/skills/foundryvtt-module-scaffold/scaffold.py:1251 (written as .github/workflows/renovate.yml)
• foundryvtt-plugin/templates/foundryvtt-module/cargo-generate.toml:21 (same path in the template's file list)

The caller passes no app-id, so reusable-renovate.yml falls back to secrets.GITHUB_TOKEN and the run authenticates as github-actions[bot].

Why it's a bug

gitops hosts a centralized autodiscover Renovate runner (RENOVATE_AUTODISCOVER=true, filter laurigates/*) that already covers every repo in the account, authenticating as the laurigates-renovate App. A generated module therefore ends up with two Renovate instances under two bot identities.

Renovate locates its dependency dashboard by title but only among issues it created — getIssues() passes user: config.renovateUsername into a GraphQL query filtered by filterBy: { createdBy: $user }. Two identities keep two dashboards, indefinitely.

Prior art

The ComfyUI pack fleet hit exactly this and deleted the repo-local workflow fleet-wide on 2026-08-16; comfyui-plugin/skills/comfyui-node-scaffold/fleet-policy.toml documents why it must stay absent, and comfyui-node-scaffold/scripts/tests/test-finishing-pass.sh:139 asserts no renovate.yml is emitted.

claude-plugins itself carried the same leftover — removed in #2707, which is what surfaced this.

Proposed fix

1. Stop emitting renovate.yml from scaffold.py and drop it from cargo-generate.toml's file list; keep renovate.json, which is what the surviving App reads (gitops/renovate-config.js sets requireConfig: "optional" and merges per-repo config on top).
2. Add the absence assertion to the scaffold's test suite, mirroring test-finishing-pass.sh.
3. Sweep already-generated foundry modules for the leftover workflow and its orphaned github-actions[bot] dashboard.

This is the code-scaffold-backport shape in reverse: the instance class was fixed for ComfyUI packs and for this repo, but a second generator still emits the defect.

Refs #2707

🤖 Generated with Claude Code

https://claude.ai/code/session_01SiP9vubrujTJNFLcmBUQvM

[laurigates]

Two modules already generated from this scaffold carry the leftover runner, for the sweep in step 3:

Repo	laurigates-renovate dashboard	github-actions[bot] dashboard	renovate/* branches
laurigates/foundryvtt-mediasoup-webrtc	laurigates/foundryvtt-mediasoup-webrtc#134	laurigates/foundryvtt-mediasoup-webrtc#139	11
laurigates/foundryvtt-render-on-demand	laurigates/foundryvtt-render-on-demand#2	laurigates/foundryvtt-render-on-demand#7	6

Both repos' .github/workflows/renovate.yml are byte-identical to the template's (cron 23 */4 * * *, reusable-renovate.yml@main with no app-id). They were added on 2026-07-01 (laurigates/foundryvtt-mediasoup-webrtc#137) and 2026-06-30 (laurigates/foundryvtt-render-on-demand@d761e6e8).

One correction to step 1 for the cargo-generate path: cargo-generate.toml:21 is the exclude list, which copies the file verbatim instead of rendering it through Liquid. It is not the list of files to emit. The template ships the workflow itself at foundryvtt-plugin/templates/foundryvtt-module/.github/workflows/renovate.yml, so dropping only the exclude entry would still emit it, this time through Liquid, which renders ${{ }} to the empty string.

The complete back-port:

• Delete templates/foundryvtt-module/.github/workflows/renovate.yml.
• Remove the exclude entry at cargo-generate.toml:21 and the comment at :12-15 about its uses: org.
• Remove RENOVATE_YML (scaffold.py:542-571) and its entry at :1251.
• Update the prose that lists or relies on it: skills/foundryvtt-module-scaffold/SKILL.md:143 (generated-files list) and :213 ("the generated renovate.yml … bumps them"), foundryvtt-plugin/README.md:43, templates/README.md:81, and the history note in test-template-parity.sh:12-13.

test-template-parity.sh compares both generators' output trees with diff -ru, so removing the file from one generator and not the other fails that gate. Neither test-template-parity.sh nor test-manifest-invariants.sh asserts that renovate.yml is absent today, so step 2 still needs a new assertion.

---

Generated by Claude Code