feat: Add client-use-post capability and POST request variants - #445
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6b70b95. Configure here.
| mockld.PollingPathContextBase64Param, // details of base64-encoded context data are tested separately | ||
| ) | ||
| return h.IfElse(method == flagRequestREPORT, | ||
| return h.IfElse(method.sendsContextInBody(), |
There was a problem hiding this comment.
Roku path matcher ignores POST
Medium Severity
The Roku polling URL-path matcher still treats only REPORT as a body method, so a POST variant falls through to the FDv1 GET prefix. availableFlagRequestMethods still adds POST when the SDK declares client-use-post, so those assertions check the wrong route instead of the FDv2 /sdk/poll/eval path.
Reviewed by Cursor Bugbot for commit 6b70b95. Configure here.
tanderson-ld
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
FDv2 client-side SDKs can send the evaluation context in the request body with
POST(the client-side FDv2usePostoption) instead of encoding it into theGETpath. The harness could only exerciseGETand, for SDKs that declareclient-use-report,REPORT.client-use-postcapability and aclientSide.usePostconfiguration parameter.POSTvariant next toGETandREPORTwhen the SDK declares the capability.POSTrequests must use the FDv2/sdk/poll/evaland/sdk/stream/evalpaths and carry the context JSON in the body. Existing test names are unchanged; the new variants are additive.REPORTwhen the SDK declaresclient-use-report, otherwisePOSTwhen it declaresclient-use-post, and skip when it declares neither.docs/service_spec.md, including the promise that the harness never setsuseReportandusePostin the same configuration, so test services do not need a precedence rule. A unit test pins that promise on the request-method configurer.Verified against the Flutter client SDK contract test service with
usePostsupport (launchdarkly/flutter-client-sdk, branchrlamb/sdk-3051/fdv2-use-post): the full v3 suite passes, 844 total, 823 ran, including 20POSTsubtests.Note
Overview
Adds
client-use-postandclientSide.usePostso FDv2 client SDKs can be contract-tested when they send streaming/polling flag requests asPOSTwith context in the body (parallel to existingREPORT/useReport).When a test service declares the capability, shared poll/stream suites gain additive
POSTsubtests: FDv2/sdk/poll/evaland/sdk/stream/eval, body assertions viasendsContextInBody()(covers bothREPORTandPOST). Auto-env-attribute body tests pickREPORTifclient-use-reportis declared, elsePOSTifclient-use-post, otherwise skip.docs/service_spec.mddocuments the capability and the rule that the harness never setsuseReportandusePosttogether; a unit test locks that onwithFlagRequestMethod.Reviewed by Cursor Bugbot for commit 6b70b95. Bugbot is set up for automated code reviews on this repo. Configure here.