Skip to content

fix: Prevent cache TTL expiry from racing read-write persistence tests #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kinyoklion wants to merge 1 commit into
base: v2
Choose a base branch
from
Draft

fix: Prevent cache TTL expiry from racing read-write persistence tests #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions sdktests/server_side_persistence_base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ func (s *ServerSidePersistentTests) Run(t *ldtest.T) {

cacheConfigs := []servicedef.SDKConfigPersistentCache{
{Mode: servicedef.CacheModeInfinite},
{Mode: servicedef.CacheModeTTL, TTL: o.Some(1)},
{Mode: servicedef.CacheModeTTL, TTL: o.Some(5)},
}

for _, cacheConfig := range cacheConfigs {
Expand Down Expand Up @@ -574,12 +574,13 @@ func (s *ServerSidePersistentTests) Run(t *ldtest.T) {
ldvalue.String("default"), ldvalue.String("fallthrough"), ldvalue.String("default")),
time.Millisecond*500, time.Millisecond*20, "uncached-flag-key was incorrectly cached")
case servicedef.CacheModeTTL:
// This key was already cached, so it shouldn't see the change above.
// This key was already cached, so it shouldn't see the change above. The check
// window plus all setup steps must fit inside the cache TTL; keep it short so
// a slow test runner cannot push the check past the cache expiry.
h.RequireNever(t,
checkForUpdatedValue(t, client, "flag-key", context,
ldvalue.String("value"), ldvalue.String("new-value"), ldvalue.String("default")),
time.Duration(
int(time.Second)*cacheConfig.TTL.Value()/2),
time.Millisecond*500,
time.Millisecond*20,
"flag-key was incorrectly updated")

Expand Down Expand Up @@ -623,7 +624,8 @@ func (s *ServerSidePersistentTests) Run(t *ldtest.T) {
h.RequireEventually(t,
checkForUpdatedValue(t, client, "flag-key", context,
ldvalue.String("value"), ldvalue.String("default"), ldvalue.String("default")),
time.Second, time.Millisecond*20, "flag-key was incorrectly cached")
time.Duration(int(time.Second)*cacheConfig.TTL.Value()),
time.Millisecond*20, "flag-key was incorrectly cached")
}
})
})
Expand Down
Loading