-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Add the FDv2 data system configuration API #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ff47890
feat: Add the FDv2 data system configuration API
beekld 7e09081
fix: Let a configured data system supersede the data source
beekld 3d6c02a
refactor: Import RequestHeaders from its own module and borrow tags
beekld 1d796e8
chore: Narrow the FDv2 dead-code allow from the whole module to speci…
beekld ec79a17
test: Gate the FDv2 default-transport test and add injected-transport…
beekld 1531765
fix: Build the FDv2 initializer factories as Arc
beekld e3d1adb
refactor: Remove the configurable FDv2 fallback and recovery timeouts
beekld 202caee
feat: Add an experimental API for implementing custom FDv2 data sources
beekld 14c20fc
fix: Default the FDv1 fallback to a polling synchronizer
beekld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| //! Types for implementing custom FDv2 data sources. | ||
| //! | ||
| //! This module is experimental and not subject to semantic versioning. Its API | ||
| //! may change in any release. | ||
|
|
||
| pub use crate::data_system_builders::{ | ||
| DataSourceBuildContext, FDv2InitializerConfig, FDv2SynchronizerConfig, | ||
| }; | ||
| pub use crate::fdv2::data_system::{InitializerFactory, SynchronizerFactory}; | ||
| pub use crate::fdv2::model::{ChangeSetKind, Selector}; | ||
| pub use crate::fdv2::request_headers::RequestHeaders; | ||
| pub use crate::fdv2::source::{ | ||
| ErrorInfo, ErrorKind, FDv1FallbackDirective, FDv2SourceEvent, FDv2SourceResult, Initializer, | ||
| Synchronizer, | ||
| }; | ||
| pub use crate::stores::change_set::{ChangeSet, ItemChange}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the builder is a concrete type, you could decide to take ownership over the builder rather than passing it in by reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it this way to be consistent with the existing
service_endpointsAPI, which is a concrete type, but takes its builder by reference and clones it like this. Does that change your suggestion, or do you still think it's worth doing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it's probably better to stay consistent. At some point, we should revisit the ownership model of this repository, but happy to stay the course for now.