fix: Deprecate the ldai module ahead of its move to go-server-sdk-ai - #444
Open
jsonbailey wants to merge 2 commits into
Open
fix: Deprecate the ldai module ahead of its move to go-server-sdk-ai#444jsonbailey wants to merge 2 commits into
jsonbailey wants to merge 2 commits into
Conversation
This reverts commit bd4ce7a. The change was never released from this repo. It already exists in github.com/launchdarkly/go-server-sdk-ai, which is now the home of the ldai module. Leaving it here would make release-please publish ldai/v0.10.0 from this repo. The new repo continues the version lineage from 0.9.x, so 0.10.0 must come from there. Ref: AIC-3306
The ldai module now lives in its own repository, github.com/launchdarkly/go-server-sdk-ai. This marks the module deprecated so `go list -m -u all` and pkg.go.dev report the move to anyone still depending on it. This is the final release of ldai from this repository. The code is removed in a follow-up change. Version numbering continues in the new repository, starting at 0.10.0. Ref: AIC-3306 Release-As: 0.9.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ldaimodule now lives in its own repository, launchdarkly/go-server-sdk-ai, released asv0.10.0. This is the final release ofldaifrom this repository. The code itself is removed in a follow-up PR.Two changes:
Revert
bd4ce7a1(feat(ldai): stamp modelKey and modelVersion on AI usage events, feat(ldai): stamp modelKey and modelVersion on AI usage events (AIC-2850) #414). That change was never released from this repo, and it already exists in the new repo as feat(ldai): stamp modelKey and modelVersion on AI usage events (AIC-2850) go-server-sdk-ai#17. Leaving it here makes release-please publishldai/v0.10.0from this repository, which collides with the version lineage — the new repo continues from0.9.x, so0.10.0must come from there.Mark the module deprecated in
ldai/go.mod:This is what surfaces the move in
go list -m -u alland on pkg.go.dev. A README only reaches people who open the repo.Release notes
This PR forces the release to
0.9.4via the footer below. Without it, release-please still sees the originalfeatcommit in the range sinceldai/v0.9.3and would propose0.10.0, which is the number the new repo has already used.The existing open release PR #424 (
chore(v7): release ldai 0.10.0) should retitle itself to0.9.4once this merges. Worth confirming rather than assuming.The older
ldaiversions are not retracted. Retraction would tell Go there is no usable version and can break@latestresolution for anyone still pinned. Deprecation is the right mechanism. Allldai/v*tags stay in place.Test plan
go build ./...inldai/go test ./...inldai/— all packages passRequirements
Related issues
Release-As: 0.9.4
Note
Overview
Prepares the in-repo
ldaipackage for its final release before the module lives only atgithub.com/launchdarkly/go-server-sdk-ai.go.modnow carries a deprecation comment sogo listand pkg.go.dev steer consumers to the new module path.The unreleased
modelKey/modelVersionwork is rolled back: those fields are removed fromdatamodel.Meta, config evaluation no longer reads them from_ldMeta, andTrackermetric payloads no longer include them (including resumption-token reconstruction).newTrackersignatures are simplified accordingly, and tests that asserted those event fields are dropped or updated.This keeps the
0.10.0version line on the new repository instead of publishing a conflictingldai/v0.10.0from this repo (intended release0.9.4per PR footer).Reviewed by Cursor Bugbot for commit 3577c5e. Bugbot is set up for automated code reviews on this repo. Configure here.