PostgreSQL connection: Username as fallback for database#3992
Closed
V02460 wants to merge 3 commits intolaunchbadge:mainfrom
Closed
PostgreSQL connection: Username as fallback for database#3992V02460 wants to merge 3 commits intolaunchbadge:mainfrom
V02460 wants to merge 3 commits intolaunchbadge:mainfrom
Conversation
43e68a3 to
6f3c014
Compare
Collaborator
|
The fallback to the username is actually done server-side. I don't think this change needs to be made, and it could be surprising to existing users of the API. If anything, maybe we just need a docs clarification here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR works on the
PgConnectOptionsto implement the fallback to the username if no database name is given. It notably touches the passfile lookup and connection establishment.The first commit is a bit broader refactor to use getter methods for fields where appropriate. This better distinguishes raw user-supplied values vs. their derived form.
Is this a breaking change?
Yes. The following changes in observable behavior are intended:
get_database(breaking)get_passwordandget_extra_float_digits(not breaking)