Make fetch_type_by_oid a non-async function returning a boxed future#3990
Closed
ngterry wants to merge 7 commits intolaunchbadge:mainfrom
Closed
Make fetch_type_by_oid a non-async function returning a boxed future#3990ngterry wants to merge 7 commits intolaunchbadge:mainfrom
ngterry wants to merge 7 commits intolaunchbadge:mainfrom
Conversation
… remove the ad-hoc boxing site.
Contributor
|
Based on pr description seems to be trying to solve around a rust compiler bug only in |
Collaborator
|
It sounds like this has been fixed upstream: #3973 (comment) |
Collaborator
|
I'm gonna go ahead and close this since the regression was fixed upstream. I appreciate the effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause: Mutual async recursion between maybe_fetch_type_info_by_oid and fetch_type_by_oid creates a very large inferred future; the extra async layer plus boxing triggers trait solver overflow when checking Send.
Solution: make fetch_type_by_oid a non-async function returning a boxed future; remove the ad-hoc boxing site.