chore(deps): Set default-features=false on sqlx in workspace.dependencies#3989
Merged
abonander merged 1 commit intolaunchbadge:mainfrom Aug 27, 2025
Merged
Conversation
Collaborator
|
I tried this but it breaks the examples. I don't want them to use |
…cies Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
a890d1b to
e96f176
Compare
Contributor
Author
It did break one of them, but I fixed it by adding |
Contributor
Author
|
The examples passed ci after the minor tweak to one of them.
|
JosiahParry
pushed a commit
to JosiahParry/sqlx
that referenced
this pull request
Sep 24, 2025
…cies (launchbadge#3989) Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
willothy
pushed a commit
to freestyle-sh/sqlx
that referenced
this pull request
Dec 5, 2025
…cies (launchbadge#3989) Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Resolves this
cargo checkwarning:Is this a breaking change?
No:
sqlx-cliwhich is already attempting to setdefault-features=falsebut that has no effect (thus the warning) because the workspace level declaration of the dependency brings in all default features.sqlx-cliis a binary crate, not a library crate