Skip to content

validate local --model-path reports 'artifact path not specified' and skips the annotation check #100

Description

@friedrichwilken

What happens

The documented invocation

model-cli validate local --model-path ./my-model

always outputs

→ Checking required annotations...
Missing required items:
  - artifact path not specified

The annotation check only runs when the undocumented --artifact-path flag is given (it is not listed in validate local --help), and even then it is a placeholder: ✓ Required annotations check (simulated).

Cause

  • cmd/validate_local.go:24-36: --artifact-path is copied into modelPath when the latter is empty, but never the other way round, so SetCheckInfo(modelPath, artifactPath) gets an empty artifactPath.
  • internal/workflow/check.go:100-116: checkAnnotations bails out on empty artifactPath and otherwise only checks that the directory exists ("simulated").

Expected

  • --model-path alone is enough (default artifactPath to modelPath, or drop the separate flag).
  • The annotation check parses manifest.json in that directory and verifies the required CNCF annotations, instead of being simulated.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions