Repository navigation
Run CI on pull requests only, and bound every job - #8
Merged
Merged
Conversation
Every branch-triggered workflow also had a pull_request trigger, so a PR from a same-repo branch ran the whole suite twice. Release workflows keep their tag trigger, and scorecard.yml keeps its branch push because OpenSSF Scorecard needs that event to publish results. Jobs had no timeout-minutes, so each inherited the 360-minute default; a job that hangs on an API call could burn six hours unnoticed. Concurrency stops superseded runs, except on publishing workflows, where cancelling a half-finished release is worse than letting it finish.
Benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eleven workflows. Four had a bare
push:(no branches or tags), so they fired on every branch and every release tag — double-running on each release. All branch-triggered workflows already hadpull_request, so nothing loses coverage.release.ymlkeeps its tag trigger and getscancel-in-progress: false— cancelling a half-finished publish is worse than letting it run.Every job now has
timeout-minutes; previously they inherited the 360-minute default.