Repository navigation
Pass a tag that is behind main only by CI commits - #34
Merged
Merged
Conversation
The release-currency check failed whenever main gained a commit, including Dependabot's weekly .github/ bumps, which ship nothing. It now passes a tag behind main only by .github/-only commits, and tells a package on real releases to cut a patch instead of moving a published tag. Same rule as laranail/package-tools' canonical script.
PHPStan 2.3.0 binds $this inside Closure::call(), so the tests' calls to FormRequest::createDefaultValidator() are now typed as the Validator contract, which has no passes(), and expect() could not resolve its type (44 errors). A typed helper, defaultValidatorFor(), asserts the concrete validator HasFluentRules returns and serves all 68 call sites. Its new unused-variable rule found three checks the tests never made; they now assert ($errors empty, the compiled custom rule present, the caught exception's class) instead of dropping the variables. Passes on both PHPStan 2.2.17 and 2.3.0; src/ is unchanged.
Benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-currency check failed whenever main gained a commit, including
Dependabot's weekly .github/ bumps, which ship nothing. It now passes a
tag behind main only by .github/-only commits, and tells a package on
real releases to cut a patch instead of moving a published tag. Same rule
as laranail/package-tools' canonical script.