Skip to content

Declare Illuminate components and expect the package-tools alias - #32

Merged
imanimanyara merged 2 commits into
mainfrom
chore/declare-illuminate
Oct 5, 2026
Merged

imanimanyara merged 2 commits into
mainfrom
chore/declare-illuminate

Conversation

@imanimanyara

Copy link
Copy Markdown
Member

FluentFormRequest extends Foundation's FormRequest and src/ calls Foundation
helpers and nine illuminate components it never declared (D3); they are now
required, and DeclaredRequirementsTest keeps it that way. package-tools 0.1.3
made hasTranslations() register the hyphen alias of laranail/validation, so
RuleMessagesResolveTest went red on main against fresh dependencies; it now
asserts the alias resolves to the canonical message, and require raises
package-tools to ^0.1.3.

FluentFormRequest extends Foundation's FormRequest and src/ calls Foundation
helpers and nine illuminate components it never declared (D3); they are now
required, and DeclaredRequirementsTest keeps it that way. package-tools 0.1.3
made hasTranslations() register the hyphen alias of laranail/validation, so
RuleMessagesResolveTest went red on main against fresh dependencies; it now
asserts the alias resolves to the canonical message, and require raises
package-tools to ^0.1.3.
Copilot AI balanced review requested due to automatic review settings October 5, 2026 13:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Benchmark results

Scenario Optimizations Native Laravel Optimized Speedup Δ vs base
Product import — 500 items, simple rules Wildcard, fast-check 173.2ms 2.9ms ~60x +0%
Nested order lines — 1000 orders × 5 line items Wildcard, fast-check (nested) 821.2ms 17.6ms ~47x -1%
Event scheduling — 100 items, field-ref dates Wildcard, partial fast-check 30.0ms 1.2ms ~25x +0%
Article submission — 50 items, custom Rule objects Wildcard only 9.6ms 2.7ms ~4x +0%
Conditional import — 100 items, 47 conditional fields Wildcard, pre-evaluation 209.2ms 44.4ms ~5x +1%
Login form — 3 fields, no wildcards Fast-check (flat) 0.1ms 0.0ms ~10x —

cognitive-complexity 1.3.0 (2026-09-29) scores the same source differently
from 1.2.0, which the baseline was written against, so every complexity
entry stopped matching and the required phpstan check went red with no code
change. Each entry now records the value 1.3.0 measures; four newly reported
ones are added at their measured values. Nothing is removed and no limit is
raised. require-dev floors the package at ^1.3 so a prefer-lowest resolve
scores on the same scale.
@imanimanyara
imanimanyara merged commit a4a3587 into main Oct 5, 2026
9 checks passed
@imanimanyara
imanimanyara deleted the chore/declare-illuminate branch October 5, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants